Turn off DI strictness #643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -87,10 +87,10 @@ end | |||
| function prepare_jacobian(prob, autodiff, fx, x) | |||
| SciMLBase.has_jac(prob.f) && return AnalyticJacobian() | |||
| if SciMLBase.isinplace(prob.f) | |||
| return DIExtras(DI.prepare_jacobian(prob.f, fx, autodiff, x, Constant(prob.p))) | |||
| return DIExtras(DI.prepare_jacobian(prob.f, fx, autodiff, x, Constant(prob.p), strict = Val(false))) | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| return DIExtras(DI.prepare_jacobian(prob.f, fx, autodiff, x, Constant(prob.p), strict = Val(false))) | |
| return DIExtras(DI.prepare_jacobian( | |
| prob.f, fx, autodiff, x, Constant(prob.p), strict = Val(false))) |
| else | ||
| x isa SArray && return DINoPreparation() | ||
| return DIExtras(DI.prepare_jacobian(prob.f, autodiff, x, Constant(prob.p))) | ||
| return DIExtras(DI.prepare_jacobian(prob.f, autodiff, x, Constant(prob.p), strict = Val(false))) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| return DIExtras(DI.prepare_jacobian(prob.f, autodiff, x, Constant(prob.p), strict = Val(false))) | |
| return DIExtras(DI.prepare_jacobian( | |
| prob.f, autodiff, x, Constant(prob.p), strict = Val(false))) |
| @@ -307,14 +307,14 @@ function prepare_vjp(::Val{false}, prob::AbstractNonlinearProblem, | |||
| @assert DI.check_inplace(autodiff) "Backend: $(autodiff) doesn't support in-place \ | |||
| problems." | |||
| fu_cache = copy(fu) | |||
| di_extras = DI.prepare_pullback(f, fu_cache, autodiff, u, (fu,), Constant(prob.p)) | |||
| di_extras = DI.prepare_pullback(f, fu_cache, autodiff, u, (fu,), Constant(prob.p), strict=Val(false)) | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| di_extras = DI.prepare_pullback(f, fu_cache, autodiff, u, (fu,), Constant(prob.p), strict=Val(false)) | |
| di_extras = DI.prepare_pullback( | |
| f, fu_cache, autodiff, u, (fu,), Constant(prob.p), strict = Val(false)) |
| return @closure (vJ, v, u, p) -> begin | ||
| DI.pullback!(f, fu_cache, (reshape(vJ, size(u)),), di_extras, autodiff, | ||
| u, (reshape(v, size(fu_cache)),), Constant(p)) | ||
| return | ||
| end | ||
| else | ||
| di_extras = DI.prepare_pullback(f, autodiff, u, (fu,), Constant(prob.p)) | ||
| di_extras = DI.prepare_pullback(f, autodiff, u, (fu,), Constant(prob.p), strict=Val(false)) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| di_extras = DI.prepare_pullback(f, autodiff, u, (fu,), Constant(prob.p), strict=Val(false)) | |
| di_extras = DI.prepare_pullback( | |
| f, autodiff, u, (fu,), Constant(prob.p), strict = Val(false)) |
| @@ -352,14 +352,14 @@ | |||
| @assert DI.check_inplace(autodiff) "Backend: $(autodiff) doesn't support in-place \ | |||
| problems." | |||
| fu_cache = copy(fu) | |||
| di_extras = DI.prepare_pushforward(f, fu_cache, autodiff, u, (u,), Constant(prob.p)) | |||
| di_extras = DI.prepare_pushforward(f, fu_cache, autodiff, u, (u,), Constant(prob.p), strict=Val(false)) | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| di_extras = DI.prepare_pushforward(f, fu_cache, autodiff, u, (u,), Constant(prob.p), strict=Val(false)) | |
| di_extras = DI.prepare_pushforward( | |
| f, fu_cache, autodiff, u, (u,), Constant(prob.p), strict = Val(false)) |
| return @closure (Jv, v, u, p) -> begin | ||
| DI.pushforward!(f, fu_cache, (reshape(Jv, size(fu_cache)),), di_extras, | ||
| autodiff, u, (reshape(v, size(u)),), Constant(p)) | ||
| return | ||
| end | ||
| else | ||
| di_extras = DI.prepare_pushforward(f, autodiff, u, (u,), Constant(prob.p)) | ||
| di_extras = DI.prepare_pushforward(f, autodiff, u, (u,), Constant(prob.p), strict=Val(false)) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| di_extras = DI.prepare_pushforward(f, autodiff, u, (u,), Constant(prob.p), strict=Val(false)) | |
| di_extras = DI.prepare_pushforward( | |
| f, autodiff, u, (u,), Constant(prob.p), strict = Val(false)) |
| @@ -375,7 +375,7 @@ | |||
|
|
|||
| @assert autodiff!==nothing "`autodiff` must be provided if `f` doesn't have \ | |||
| analytic `vjp` or `jvp` or `jac`." | |||
| di_extras = DI.prepare_derivative(f, autodiff, u, Constant(prob.p)) | |||
| di_extras = DI.prepare_derivative(f, autodiff, u, Constant(prob.p), strict=Val(false)) | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| di_extras = DI.prepare_derivative(f, autodiff, u, Constant(prob.p), strict=Val(false)) | |
| di_extras = DI.prepare_derivative(f, autodiff, u, Constant(prob.p), strict = Val(false)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that DI strictness does not allow views, even though most of the AD engines are fine with views.