Skip to content

fix reorder_unknowns #3833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2025
Merged

fix reorder_unknowns #3833

merged 2 commits into from
Jul 22, 2025

Conversation

baggepinnen
Copy link
Contributor

@baggepinnen baggepinnen commented Jul 21, 2025

Close #3814

Copy link
Contributor

github-actions bot commented Jul 21, 2025

Benchmark Results (Julia vlts)

Time benchmarks
master 73227f0... master / 73227f0...
ODEProblem 0.0843 ± 0.0058 s 0.0843 ± 0.0055 s 0.999 ± 0.095
init 0.0613 ± 0.0019 ms 0.062 ± 0.0018 ms 0.988 ± 0.042
large_parameter_init/ODEProblem 0.706 ± 0.0048 s 0.716 ± 0.0041 s 0.986 ± 0.0087
large_parameter_init/init 0.112 ± 0.0025 ms 0.112 ± 0.0022 ms 0.999 ± 0.03
mtkcompile 0.0349 ± 0.0014 s 0.0351 ± 0.00093 s 0.996 ± 0.048
time_to_load 5.62 ± 0.017 s 5.75 ± 0.034 s 0.977 ± 0.0065
Memory benchmarks
master 73227f0... master / 73227f0...
ODEProblem 0.588 M allocs: 20.1 MB 0.588 M allocs: 20 MB 1
init 0.908 k allocs: 0.0479 MB 0.908 k allocs: 0.0479 MB 1
large_parameter_init/ODEProblem 4.62 M allocs: 0.178 GB 4.64 M allocs: 0.179 GB 0.998
large_parameter_init/init 1.75 k allocs: 0.0874 MB 1.75 k allocs: 0.0874 MB 1
mtkcompile 0.233 M allocs: 8.64 MB 0.233 M allocs: 8.64 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

Copy link
Contributor

github-actions bot commented Jul 21, 2025

Benchmark Results (Julia v1)

Time benchmarks
master 73227f0... master / 73227f0...
ODEProblem 0.0796 ± 0.0043 s 0.0791 ± 0.0031 s 1.01 ± 0.067
init 0.0489 ± 0.012 ms 0.0571 ± 0.012 ms 0.857 ± 0.27
large_parameter_init/ODEProblem 0.729 ± 0.025 s 0.706 ± 0.018 s 1.03 ± 0.045
large_parameter_init/init 0.1 ± 0.011 ms 0.1 ± 0.012 ms 0.999 ± 0.16
mtkcompile 0.034 ± 0.00067 s 0.0335 ± 0.00041 s 1.02 ± 0.024
time_to_load 5.79 ± 0.062 s 5.7 ± 0.011 s 1.02 ± 0.011
Memory benchmarks
master 73227f0... master / 73227f0...
ODEProblem 0.579 M allocs: 18.9 MB 0.578 M allocs: 18.8 MB 1
init 0.815 k allocs: 0.0318 MB 0.815 k allocs: 0.0318 MB 1
large_parameter_init/ODEProblem 4.71 M allocs: 0.171 GB 4.68 M allocs: 0.169 GB 1.01
large_parameter_init/init 1.66 k allocs: 0.0712 MB 1.66 k allocs: 0.0712 MB 1
mtkcompile 0.233 M allocs: 8.08 MB 0.232 M allocs: 8.07 MB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

@AayushSabharwal AayushSabharwal merged commit 859e4d6 into master Jul 22, 2025
45 of 51 checks passed
@AayushSabharwal AayushSabharwal deleted the sim_trans branch July 22, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModelingToolkit.reorder_unknowns() returns the wrong permutation?
2 participants