Skip to content

fix: fix parameter dependencies dependent on scalarized array parameter #3822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2025

Conversation

AayushSabharwal
Copy link
Member

No description provided.

Copy link
Contributor

Benchmark Results (Julia vlts)

Time benchmarks
master 8a5d6a0... master / 8a5d6a0...
ODEProblem 0.0826 ± 0.0059 s 0.083 ± 0.0065 s 0.996 ± 0.11
init 0.0619 ± 0.0018 ms 0.0619 ± 0.0019 ms 0.999 ± 0.043
large_parameter_init/ODEProblem 0.703 ± 0.0065 s 0.703 ± 0.0075 s 1 ± 0.014
large_parameter_init/init 0.113 ± 0.0024 ms 0.112 ± 0.0023 ms 1.01 ± 0.03
mtkcompile 0.0346 ± 0.00076 s 0.0345 ± 0.00084 s 1 ± 0.033
time_to_load 5.64 ± 0.027 s 5.63 ± 0.011 s 1 ± 0.0052
Memory benchmarks
master 8a5d6a0... master / 8a5d6a0...
ODEProblem 0.588 M allocs: 20 MB 0.588 M allocs: 20 MB 1
init 0.908 k allocs: 0.0479 MB 0.908 k allocs: 0.0479 MB 1
large_parameter_init/ODEProblem 4.58 M allocs: 0.176 GB 4.61 M allocs: 0.177 GB 0.993
large_parameter_init/init 1.75 k allocs: 0.0874 MB 1.75 k allocs: 0.0874 MB 1
mtkcompile 0.233 M allocs: 8.64 MB 0.233 M allocs: 8.64 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

Copy link
Contributor

Benchmark Results (Julia v1)

Time benchmarks
master 8a5d6a0... master / 8a5d6a0...
ODEProblem 0.0853 ± 0.0045 s 0.0849 ± 0.0057 s 1 ± 0.086
init 0.0572 ± 0.012 ms 0.0491 ± 0.012 ms 1.17 ± 0.39
large_parameter_init/ODEProblem 0.728 ± 0.027 s 0.763 ± 0.04 s 0.954 ± 0.061
large_parameter_init/init 0.101 ± 0.012 ms 0.1 ± 0.013 ms 1 ± 0.18
mtkcompile 0.0373 ± 0.0013 s 0.0367 ± 0.00095 s 1.01 ± 0.044
time_to_load 5.99 ± 0.035 s 6.06 ± 0.026 s 0.989 ± 0.0071
Memory benchmarks
master 8a5d6a0... master / 8a5d6a0...
ODEProblem 0.579 M allocs: 18.9 MB 0.578 M allocs: 18.8 MB 1
init 0.815 k allocs: 0.0318 MB 0.815 k allocs: 0.0318 MB 1
large_parameter_init/ODEProblem 4.65 M allocs: 0.168 GB 4.68 M allocs: 0.169 GB 0.992
large_parameter_init/init 1.66 k allocs: 0.0712 MB 1.66 k allocs: 0.0712 MB 1
mtkcompile 0.233 M allocs: 8.08 MB 0.232 M allocs: 8.08 MB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

@AayushSabharwal AayushSabharwal merged commit d1cde76 into master Jul 18, 2025
48 of 50 checks passed
@AayushSabharwal AayushSabharwal deleted the as/fix-pdeps branch July 18, 2025 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants