Skip to content

pass the order variable to MOLFiniteDifference #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

j-bowhay
Copy link

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

I noticed a few of the tutorials define an order variable but then never uses it which is mildly confusing to read. In this pr is pass this variable to the approx_order argument of MOLFiniteDifference.

@ChrisRackauckas
Copy link
Member

In all of the cases here the order is just the default approximation order. Is it easier to read just removing it?

@j-bowhay
Copy link
Author

In all of the cases here the order is just the default approximation order. Is it easier to read just removing it?

Equally happy to do that but I thought maybe it would be worth keeping to draw attention to the fact you can change it?

@ChrisRackauckas
Copy link
Member

That's why it's a question. Unsure. @xtalax your take?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants