Skip to content

Fix default adjoint for AppleAccelerate and MKL #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2025

Conversation

ChrisRackauckas
Copy link
Member

This can't be easily tested because it's very architecture-dependent, but it fixes #601

This can't be easily tested because it's very architecture-dependent, but it fixes #601
@@ -28,6 +28,14 @@ specific structure distinct from ``A`` then passing in a `linsolve` will be more
linsolve::L = missing
end

function CRC.rrule(T::typeof(SciMLBase.solve), prob::LinearProblem, alg::Nothing, args...; kwargs...)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
function CRC.rrule(T::typeof(SciMLBase.solve), prob::LinearProblem, alg::Nothing, args...; kwargs...)
function CRC.rrule(
T::typeof(SciMLBase.solve), prob::LinearProblem, alg::Nothing, args...; kwargs...)

@ChrisRackauckas ChrisRackauckas merged commit a1d4601 into main May 3, 2025
18 of 32 checks passed
@ChrisRackauckas ChrisRackauckas deleted the adjoint_default_mklaa branch May 3, 2025 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zygote gradient fails on LinearSolve for more than 10 x 10 matrix
1 participant