Add optional extrapolation methods #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs tests that this actually does what is expected. |
SouthEndMusic
previously approved these changes
May 26, 2025
src/integral_inverses.jl
Outdated
Comment on lines
112
to
113
| function invert_integral(A::ConstantInterpolation{<:AbstractVector{<:Number}}, | ||
| extrapolation_left::ExtrapolationType.T = A.extrapolation_left, |
There was a problem hiding this comment.
Suggested change
| function invert_integral(A::ConstantInterpolation{<:AbstractVector{<:Number}}, | |
| extrapolation_left::ExtrapolationType.T = A.extrapolation_left, | |
| function invert_integral( | |
| A::ConstantInterpolation{<:AbstractVector{<:Number}}; | |
| extrapolation_left::ExtrapolationType.T = A.extrapolation_left, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Before, invert_integral inherits the extrapolation method from the interpolation it got in its construction.
If we did a piecewise linear interpolation with constant extrapolation, the inverted integral would not integrate beyond the input data. With this change, we can set the extrapolation method of invert_integral independent of the interpolation.