Skip to content

Fix get_transition_ts #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025
Merged

Fix get_transition_ts #432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/interpolation_utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,18 +392,17 @@ function smooth_arc_length_params_2(u_int, uⱼ, uⱼ₊₁)
end

function get_transition_ts(A::SmoothedConstantInterpolation)
out = similar(A.t, 3 * length(A.t))
out = similar(A.t, 3 * length(A.t) - 2)

for idx in 1:(length(A.t) - 1)
d_lower, d_upper, _, _ = get_parameters(A, idx)
if idx == 1
out[1] = A.t[1]
out[2] = A.t[1]
out[3] = A.t[1] + d_lower
out[2] = A.t[1] + d_lower
else
out[3idx - 2] = A.t[idx] - d_upper
out[3idx - 1] = A.t[idx]
out[3idx] = A.t[idx] + d_lower
out[3idx - 3] = A.t[idx] - d_upper
out[3idx - 2] = A.t[idx]
out[3idx - 1] = A.t[idx] + d_lower
end
end

Expand Down
2 changes: 2 additions & 0 deletions test/interpolation_tests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,6 +627,8 @@ end
A = SmoothedConstantInterpolation(u, t; d_max)
test_cached_index(A)

@test DataInterpolations.get_transition_ts(A) == [
1.2, 1.7, 2.0, 2.5, 3.0, 5.2, 5.7, 6.2, 8.2, 8.7]
@test A(1.9) == u[1]
@test A(3.1) == u[2]
@test A(2.5) ≈ (u[1] + u[2]) / 2
Expand Down
Loading