Skip to content

use isequal instead of == in safe_diff #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2025
Merged

Conversation

vyudu
Copy link
Member

@vyudu vyudu commented May 2, 2025

This would make interpolation on symbolic arrays work, e.g.

@variables x[1:101]
t = 0.:0.01:1
LinearInterpolation(x, t)

would work as expected (would throw errors before).

@vyudu
Copy link
Member Author

vyudu commented May 2, 2025

@ChrisRackauckas this would make things nicer for CasADi symbolic objects because it doesn’t have built in interpolation, so being able to just use DataInterpolations machinery would be nice

ChrisRackauckas
ChrisRackauckas previously approved these changes May 2, 2025
@ChrisRackauckas
Copy link
Member

Put a test on this?

@vyudu
Copy link
Member Author

vyudu commented May 2, 2025

Marked out the ones that work and don't in the test, should I document this soemwhere?

@ChrisRackauckas
Copy link
Member

Open an issue to follow up on those.

@ChrisRackauckas ChrisRackauckas merged commit 5f029a7 into SciML:master May 3, 2025
15 of 16 checks passed
@vyudu vyudu deleted the sym branch May 3, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants