Add output_size
#413
Closed
Add output_size
#413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Sounds reasonable, but not sure what your comment means for this PR. |
|
Converted to draft until we are sure this is what SparseConnectivityTracer really needs, see adrhill/SparseConnectivityTracer.jl#234 (comment). |
|
It is clear now that this would be needed to finish adrhill/SparseConnectivityTracer.jl#234 properly. |
|
Something odd happened here: I merged this but it displays as closed 🤔 @visr didn't close the PR. When merging there was an error message saying something like "the server could not be reached". |
|
😅 Just make a new PR? |
|
No need, despite the red closed icon, it is on master as intended. |
SebastianM-C
pushed a commit
to SebastianM-C/DataInterpolations.jl
that referenced
this pull request
Apr 9, 2025
Add `output_size`
oscardssmith
added a commit
that referenced
this pull request
Apr 30, 2025
we need a new version for #413
Merged
ChrisRackauckas
pushed a commit
that referenced
this pull request
Apr 30, 2025
we need a new version for #413
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to update SparseConnectivityTracer to DataInterpolations v8 in adrhill/SparseConnectivityTracer.jl#234 but got a bit confused.
#396 removes the output dimension type parameter and the old
get_output_dim. Even though it talks about dimensions it was really thesizeof the output.SparseConnectivityTracer was one of the reasons
output_dimwas added to the API, but this actually was thendimsof the output (perhapsoutput_ndimswould be a better name). But that is not what SparseConnectivityTracer needs. Hence I am proposing to addoutput_size, such that this code doesn't have to live in SparseConnectivityTracer.