Skip to content

Support ForwardDiff 1.0 #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 6, 2025
Merged

Support ForwardDiff 1.0 #302

merged 4 commits into from
Apr 6, 2025

Conversation

ErikQQY
Copy link
Member

@ErikQQY ErikQQY commented Apr 5, 2025

Let's see if the upgrade breaks anything

Copy link
Contributor

github-actions bot commented Apr 5, 2025

Benchmark Results

master 51b362f... master / 51b362f...
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK2() 7.71 ± 0.22 ms 7.87 ± 0.26 ms 0.979
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK3() 2.87 ± 0.18 ms 2.89 ± 0.19 ms 0.991
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK4() 0.997 ± 0.082 ms 1 ± 0.077 ms 0.993
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK5() 2.55 ± 0.45 ms 2.58 ± 0.46 ms 0.988
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK6() 1.17 ± 0.15 ms 1.17 ± 0.15 ms 0.999
Simple Pendulum/IIP/MultipleShooting(10, Tsit5; grid_coarsening = false) 1.89 ± 0.66 ms 1.9 ± 0.66 ms 0.998
Simple Pendulum/IIP/MultipleShooting(10, Tsit5; grid_coarsening = true) 3.16 ± 1 ms 3.15 ± 1 ms 1
Simple Pendulum/IIP/MultipleShooting(100, Tsit5; grid_coarsening = false) 0.0708 ± 0.02 s 0.0709 ± 0.021 s 0.999
Simple Pendulum/IIP/MultipleShooting(100, Tsit5; grid_coarsening = true) 0.085 ± 0.022 s 0.0841 ± 0.022 s 1.01
Simple Pendulum/IIP/Shooting(Tsit5()) 0.265 ± 0.085 ms 0.257 ± 0.082 ms 1.03
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK2() 9.1 ± 0.41 ms 9.09 ± 0.36 ms 1
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK3() 3.33 ± 0.15 ms 3.34 ± 0.15 ms 0.998
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK4() 1.16 ± 0.088 ms 1.16 ± 0.095 ms 1
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK5() 2.98 ± 0.48 ms 2.97 ± 0.38 ms 1
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK6() 1.39 ± 0.13 ms 1.39 ± 0.14 ms 0.997
Simple Pendulum/OOP/MultipleShooting(10, Tsit5; grid_coarsening = false) 3.45 ± 2.9 ms 3.49 ± 3.1 ms 0.99
Simple Pendulum/OOP/MultipleShooting(10, Tsit5; grid_coarsening = true) 5.85 ± 4.9 ms 5.94 ± 5.5 ms 0.985
Simple Pendulum/OOP/MultipleShooting(100, Tsit5; grid_coarsening = false) 0.122 ± 0.0097 s 0.121 ± 0.017 s 1.02
Simple Pendulum/OOP/MultipleShooting(100, Tsit5; grid_coarsening = true) 0.148 ± 0.024 s 0.149 ± 0.017 s 0.992
Simple Pendulum/OOP/Shooting(Tsit5()) 0.637 ± 0.048 ms 0.642 ± 0.065 ms 0.993
time_to_load 4.97 ± 0.018 s 4.97 ± 0.009 s 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@ErikQQY ErikQQY merged commit 9e78ac9 into master Apr 6, 2025
29 of 30 checks passed
@devmotion
Copy link
Member

Tests (eg of Core) did not run with ForwardDiff 1. ForwardDiff 1 seems untested.

@ErikQQY
Copy link
Member Author

ErikQQY commented Apr 6, 2025

Indeed, we first need ForwardDiff 1 on upstream packages like NonlinearSolve in SciML/NonlinearSolve.jl#561

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants