feat: add all companies to the evu picker (#482) #1341
+125
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobe-official
changed the title
# Conflicts: # das_client/app/ios/Podfile.lock
tobe-official
requested review from
Grodien,
faebum,
mghilardelli,
phirzel,
rawi-coding and
smallTrogdor
as code owners
rawi-coding
requested changes
Oct 17, 2025
| "w_additional_speed_restriction_modal_table_label_until": "Bis", | ||
| "w_additional_speed_restriction_modal_table_label_reason": "Grund", | ||
| "c_ru_sbb_p": "SBB", | ||
| "c_ru_sbb": "SBB AG", |
There was a problem hiding this comment.
Hast du hier abgeklärt, wann welcher Text verwendet werden soll? Laut der Confluence-Seite sehe ich zumindest keine Logik, da manchmal Short Name oder Name oder ein Gemisch davon verwendet wird 😄
| "c_ru_bls_p": "BLS", | ||
| "c_ru_sbbc_int": "SBB Cargo International", | ||
| "c_ru_sbb_d": "SBB GmbH Deutschland", | ||
| "c_ru_sbb_infra_baulog": "SBB Infrastruktur Baulogistik", |
There was a problem hiding this comment.
Die Keys sind etwas inkonsistent. Beispielsweise verwendet du für Infrastruktur manchmal infra oder i. Falls das keine offiziellen Abkürzungen sind, würde ich das vereinheitlichen.
| "c_ru_ra": "RegionAlps SA", | ||
| "c_ru_travys": "TRAVYS SA", | ||
| "c_ru_transn": "transN", | ||
| "c_ru_tpfinfra": "TPF Infra SA", |
There was a problem hiding this comment.
Würde die Keys gleich machen wie bei z.B. den anderen EVU (c_ru_sob_x, c_ru_sbb_x, c_ru_bls_x, ...), also c_ru_tpf_x.
| ), | ||
| onTap: () { | ||
| final radius = Radius.circular(16); | ||
| showModalBottomSheet( |
There was a problem hiding this comment.
Wie besproche, clipBehavior von showModalBottomSheet verwenden :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I added the EVU's which are listed here:
https://confluence.sbb.ch/spaces/DASBP/pages/2995226950/EVU-Liste+DAS