Skip to content

Add maru-runner JSON schema #4803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

joonas
Copy link

@joonas joonas commented Jun 21, 2025

This PR adds a new JSON Schema for maru-runner, Defense Unicorn's open source task runner tool.

Signed-off-by: Joonas Bergius <joonas@bergi.us>
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

@hyperupcall
Copy link
Member

hyperupcall commented Jun 24, 2025

Thanks - is it possible to have a more generic fileMatch the current one is likely to have many false positives (more details about that in CONTRIBUTING.md)

@joonas
Copy link
Author

joonas commented Jun 24, 2025

Thanks - is it possible to have a more generic fileMatch the current one is likely to have many false positives (more details about that in CONTRIBUTING.md)

Hey @hyperupcall, in practice we often see Maru Runner files under a tasks/ directory (see for example tasks/*.yaml across defenseunicorns organization), but I noticed that this would conflict with Ansible Tasks files - it seemed from the validation in the repository that overlapping patterns are discouraged in general, so I settled for a more generic pattern that still happens in practice.

Do you have a recommendation for the best way to move forward so as to not create an overly generic matcher here?

"name": "Maru Runner",
"description": "The Unicorn Task Runner",
"fileMatch": ["tasks.yaml"],
"url": "https://json.schemastore.org/maru-runner.json"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use www subdomain instead of json

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thank you!

…tore.org

Signed-off-by: Joonas Bergius <joonas@defenseunicorns.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants