Skip to content

Conversation

iainelder
Copy link
Contributor

The previous version of this test meant to use bash, but really used sh.

Improves first PR #1523.

PR Checklist

  • Wrote a good commit message & description [see guide below].
  • Commit message starts with [Resolve #issue-number].
  • Added/Updated unit tests.
  • Added/Updated integration tests (if applicable).
  • All unit tests (poetry run tox) are passing.
  • Used the same coding conventions as the rest of the project.
  • The new code passes pre-commit validations (poetry run pre-commit run --all-files).
  • The PR relates to only one subject with a clear title.
    and description in grammatically correct, complete sentences.

Approver/Reviewer Checklist

  • Before merge squash related commits.

Other Information

Guide to writing a good commit

The previous version of this test meant to use bash, but really
used sh.

Improves first PR Sceptre#1523.
@iainelder iainelder requested a review from dboitnot April 4, 2025 15:17
@iainelder
Copy link
Contributor Author

@dboitnot , does this still work on Nix?

@zaro0508 zaro0508 requested a review from alex-harvey-z3q April 4, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants