Fix node affinity #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partially fixes #45 we still need to "terraform apply" twice Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
domendobnikar
approved these changes
May 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #45 .
Provider needs to read
PreferredNodeUUIDfrom HyperCore, after VM is started.Complication is that VM is started by
hypercore_vm_power_state, and this one cannot updatehypercore_vm. This means we need to callterraform applytwice - on second invocationhypercore_vmwill noticePreferredNodeUUIDwas changed on HyperCore side, and will write this value into terraform state.Second complication is
affinity_strategyis now mandatory. At least it can be justaffinity_strategy={}.