Skip to content

58 acceptance tests are failing #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2025
Merged

58 acceptance tests are failing #63

merged 2 commits into from
May 20, 2025

Conversation

domendobnikar
Copy link
Collaborator

@domendobnikar domendobnikar commented May 20, 2025 •
edited
Loading

Closes #58
What was done in this PR:

  • Updated CI/CD setup documentation
  • Fixed issues with SMB import acceptance test
  • Added ISO cleanup logic to the acceptance test setup file
  • Moved SMB credentials to be apart of Action variables in Github instead of env file, makes more sense due to login credentials being present

@domendobnikar domendobnikar linked an issue May 20, 2025 that may be closed by this pull request
Acceptance tests are failing #58
Closed
@domendobnikar domendobnikar self-assigned this May 20, 2025
justinc1
justinc1 approved these changes May 20, 2025
View reviewed changes
Copy link
Collaborator

@justinc1 justinc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. TY!

@justinc1 justinc1 merged commit 1163070 into main May 20, 2025
4 checks passed
@justinc1 justinc1 deleted the 58-acceptance-tests-are-failing branch May 20, 2025 13:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@justinc1 justinc1 justinc1 approved these changes

@anazobec anazobec Awaiting requested review from anazobec

Assignees

@domendobnikar domendobnikar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Acceptance tests are failing
2 participants
@domendobnikar @justinc1