Skip to content

Preserve mac address logic for VM clone #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 19, 2025
Merged

Preserve mac address logic for VM clone #57

merged 4 commits into from
May 19, 2025

Conversation

domendobnikar
Copy link
Collaborator

Closes #48
What was done in this PR:

  • Preserve mac address logic added to VM clone
  • Now Clone logic keeps the net devices from source and user can specific to keep MAC addresses from source VM

@domendobnikar domendobnikar linked an issue May 15, 2025 that may be closed by this pull request
hypercore_vm clone option should allow either preserving mac addresses or creating new like hypercore UI #48
Closed
@domendobnikar domendobnikar force-pushed the 48-hypercore_vm-clone-option-should-allow-either-preserving-mac-addresses-or-creating-new-like-hypercore-ui branch from 1226285 to f3497f8 Compare May 15, 2025 14:37
justinc1
justinc1 requested changes May 16, 2025
View reviewed changes
Copy link
Collaborator

@justinc1 justinc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve, I'm asking only for one small change - the preserve_mac_address should be false by default.

A dedicated test to check cloned MAC address is correct would be nice. But we first merge this, and can add test later.

@domendobnikar domendobnikar self-assigned this May 19, 2025
@domendobnikar
Copy link
Collaborator Author

I approve, I'm asking only for one small change - the preserve_mac_address should be false by default.

A dedicated test to check cloned MAC address is correct would be nice. But we first merge this, and can add test later.

I changed Clone schema to use SingleNestedAttribute instead.
Added Optional, Required and Default values where needed.
Updated documentation.

@domendobnikar domendobnikar force-pushed the 48-hypercore_vm-clone-option-should-allow-either-preserving-mac-addresses-or-creating-new-like-hypercore-ui branch from 4f93e66 to d9bc0ef Compare May 19, 2025 08:43
@domendobnikar domendobnikar merged commit 96022cd into main May 19, 2025
6 of 8 checks passed
@domendobnikar domendobnikar deleted the 48-hypercore_vm-clone-option-should-allow-either-preserving-mac-addresses-or-creating-new-like-hypercore-ui branch May 19, 2025 08:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@justinc1 justinc1 justinc1 requested changes

@anazobec anazobec Awaiting requested review from anazobec

Assignees

@domendobnikar domendobnikar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hypercore_vm clone option should allow either preserving mac addresses or creating new like hypercore UI
2 participants
@domendobnikar @justinc1