Skip to content

Allow modifying disks' flash priority #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2025

Conversation

anazobec
Copy link
Collaborator

@anazobec anazobec commented May 12, 2025

Closes #46

Changed hypercore_disk resource to allow modifying disk's flash priority:

  • added flash_priority parameter - in HC3 API this is tieringPriorityFactor

TODO:

  • testing and fixing

@anazobec anazobec requested a review from justinc1 May 12, 2025 13:01
@anazobec anazobec self-assigned this May 12, 2025
@anazobec anazobec force-pushed the 46-hypercore_disk-allow-modifying-flash-priority branch from 3eff6ca to cd7d34f Compare May 13, 2025 08:27
@anazobec anazobec changed the title Draft: Allow modifying disks' flash priority Allow modifying disks' flash priority May 13, 2025
@anazobec anazobec requested a review from domendobnikar May 13, 2025 11:33
Copy link
Collaborator

@domendobnikar domendobnikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're missing priority mapping here like it was done for Ansible Collection.
Example in ansible colletion code

@anazobec anazobec force-pushed the 46-hypercore_disk-allow-modifying-flash-priority branch 3 times, most recently from 6458681 to a2a7bec Compare May 14, 2025 11:19
@anazobec anazobec requested a review from domendobnikar May 14, 2025 11:20
@justinc1 justinc1 force-pushed the 46-hypercore_disk-allow-modifying-flash-priority branch from 5056d3a to 6eb0799 Compare May 15, 2025 07:23
Copy link
Collaborator

@justinc1 justinc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Ana

anazobec and others added 2 commits May 15, 2025 09:27
Changed hypercore_disk resource to allow modifying disk's flash
priority:
* added `flash_priority` parameter - in HC3 API this is
`tieringPriorityFactor`
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
@justinc1 justinc1 force-pushed the 46-hypercore_disk-allow-modifying-flash-priority branch from 6eb0799 to 7bfeea8 Compare May 15, 2025 07:28
@justinc1 justinc1 merged commit 1dc8466 into main May 15, 2025
3 of 4 checks passed
@justinc1 justinc1 deleted the 46-hypercore_disk-allow-modifying-flash-priority branch May 15, 2025 07:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hypercore_disk should allow setting/updating flash priority
3 participants