Change hypercore_vm group parameter to list of tags #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anazobec
force-pushed
the
49-allow-manipulating-list-of-vm-tags
branch
from
3a40761 to
d2848da
Compare
|
@justinc1 Upon a quick self-review before merge, I found I forgot to also modify the integration tests - replace |
anazobec
force-pushed
the
49-allow-manipulating-list-of-vm-tags
branch
from
d2848da to
2f939a3
Compare
Changed the VM's group parameter to list of tags. - before: `group = "my-group-tag"` - now: `tags = ["tag1", "tag2", ...]` Updated integration tests - `group` -> `tags`
anazobec
force-pushed
the
49-allow-manipulating-list-of-vm-tags
branch
from
2f939a3 to
02fcdc9
Compare
domendobnikar
approved these changes
May 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #49
This MR changes the VM's group parameter to list of tags.
group = "my-group-tag"tags = ["tag1", "tag2", ...]