Use SOURCE_VM_UUID also for TestAccHypercoreVMResourceClone #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SOURCE_VM_UUID/NAME was introduced in 620b34f. Use it as much as possible. Test correct VM was cloned - check disk size. Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just wanted to test against our NUC HyperCore. The hardcoded VM UUID was replaces with the SOURCE_VM_UUID/NAME (introduced in 620b34f).
Next I had problem why wrong source VM is cloned. Problem was, I forgot to source env.txt file. PR adds this to Makefile - Makefile now loads the env.txt file.
To be really sure correct VM was cloned, the disk size is checked.