Remove running VM #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
domendobnikar
approved these changes
Apr 17, 2025
There was a problem hiding this comment.
Looks good 👍 , thank you @justinc1
I would comment that the current Delete logic for VMPowerState is only handling cases where we go from RUNNING to SHUTOFF other situations are currently not covered
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fixes removal of running VM. Problem is we try to delete also disks while the VM is running, and this delete disk fails.
The hypercore_vm_power_state and hypercore_vm_power_state have 1:1 relationship. So we can use hypercore_vm_power_state.Delete to shutdown VM, before it disks and VM are deleted.