Skip to content

VM import #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 16, 2025
Merged

VM import #36

merged 7 commits into from
Apr 16, 2025

Conversation

domendobnikar
Copy link
Collaborator

@domendobnikar domendobnikar commented Apr 14, 2025 •
edited
Loading

Closes #28
What was done in this PR:

  • Implemented VM import resource
  • Did small cleanup of Utils (naming conventions, error handling etc.)
  • Code cleanup for VM resource (changed Create method workflow)
  • Changed VM resource schema (Now user can chose between Import or Clone)
  • Updated docs
  • Added example for VM import
  • Fixed Github action issue where we had two of the same actions being trigger on PR merge
  • Divided VM tests into Import and Clone acceptance tests (Made two test files that are not connected - better test experience)
  • Added Github secret for SMB into Github project settings

@domendobnikar domendobnikar mentioned this pull request Apr 14, 2025
Closed
@domendobnikar domendobnikar self-assigned this Apr 14, 2025
anazobec
anazobec approved these changes Apr 16, 2025
View reviewed changes
Copy link
Collaborator

@anazobec anazobec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a LGTM from me. Thanks @domendobnikar!

justinc1
justinc1 approved these changes Apr 16, 2025
View reviewed changes
Copy link
Collaborator

@justinc1 justinc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, ty.

@justinc1 justinc1 merged commit 6ec90b6 into main Apr 16, 2025
4 checks passed
@justinc1 justinc1 deleted the implement_vm_import branch April 16, 2025 20:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@justinc1 justinc1 justinc1 approved these changes

@anazobec anazobec anazobec approved these changes

Assignees

@domendobnikar domendobnikar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a VM from an SMB drive VM definition
3 participants
@domendobnikar @justinc1 @anazobec