Fix vm shutdown #34
Merged
Fix vm shutdown #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We always use cause=INTERNAL. Compute json payload inside ModifyVMPowerState. Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
anazobec
requested changes
Apr 10, 2025
Comment on lines
457
to
471
| var waitSleep time.Duration = 5 | ||
| var waitTime time.Duration = 0 | ||
| for { | ||
| // wait on VM to stop | ||
| currentState, err := utils.GetVMPowerState(vmUUID, *restClient) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| if currentState == "SHUTOFF" { | ||
| return nil | ||
| } | ||
| if waitTime > maxWaitTime { | ||
| break | ||
| } | ||
| time.Sleep(waitSleep * time.Second) |
There was a problem hiding this comment.
For this linter error: Multiplication of durations: 'waitSleep * time.Second' (durationcheck). Apparently this is a common occurrence in Golang.
According to research, time.Duration is just another way of saying int64. So a way to fix this could be the following:
Suggested change
| var waitSleep time.Duration = 5 | |
| var waitTime time.Duration = 0 | |
| for { | |
| // wait on VM to stop | |
| currentState, err := utils.GetVMPowerState(vmUUID, *restClient) | |
| if err != nil { | |
| return err | |
| } | |
| if currentState == "SHUTOFF" { | |
| return nil | |
| } | |
| if waitTime > maxWaitTime { | |
| break | |
| } | |
| time.Sleep(waitSleep * time.Second) | |
| var waitSleep time.Duration = 5 * time.Second // from ns to s | |
| var waitTime time.Duration = 0 | |
| for { | |
| // wait on VM to stop | |
| currentState, err := utils.GetVMPowerState(vmUUID, *restClient) | |
| if err != nil { | |
| return err | |
| } | |
| if currentState == "SHUTOFF" { | |
| return nil | |
| } | |
| if waitTime > maxWaitTime { | |
| break | |
| } | |
| time.Sleep(waitSleep) |
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
justinc1
force-pushed
the
fix-vm-shutdown
branch
from
e52ff6a to
a1e7a08
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shutdown VM before DELETE. Timeout can be set with environ HC_VM_SHUTDOWN_TIMEOUT.