Skip to content

Acceptance tests #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

Acceptance tests #33

merged 1 commit into from
Apr 10, 2025

Conversation

domendobnikar
Copy link
Collaborator

What was done in this PR:

  • Added missing acceptance test for nic, disk, power state, boot order, iso, virtual disk

@domendobnikar domendobnikar self-assigned this Apr 10, 2025
justinc1
justinc1 approved these changes Apr 10, 2025
View reviewed changes
Copy link
Collaborator

@justinc1 justinc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I actually had problem with TestAccHypercoreBootOrderResource - this is what we "want"!

@justinc1 justinc1 merged commit 9dd791a into main Apr 10, 2025
11 of 12 checks passed
@justinc1 justinc1 deleted the acceptance-tests branch April 10, 2025 14:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@justinc1 justinc1 justinc1 approved these changes

@anazobec anazobec Awaiting requested review from anazobec

Assignees

@domendobnikar domendobnikar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domendobnikar @justinc1