Skip to content

Implement hypercore_vm_replication resource #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2025

Conversation

anazobec
Copy link
Collaborator

@anazobec anazobec commented Mar 31, 2025

This PR implements a hypercore_vm_replication resource to allow users to create VM replications.

@justinc1, to test this, you can use local/main.tf.

For more info, check the regenerated docs for this resource.

@anazobec anazobec requested a review from justinc1 March 31, 2025 10:17
@anazobec anazobec self-assigned this Mar 31, 2025
@anazobec
Copy link
Collaborator Author

In local/main.tf is the suggestion of how this resource will look like.

@anazobec anazobec force-pushed the hypercore_vm_replication branch 5 times, most recently from 3e999f3 to 2679745 Compare April 1, 2025 10:39
Copy link
Collaborator

@justinc1 justinc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY, LGTM. Tested code, it works.

},
},
"connection_uuid": schema.StringAttribute{
MarkdownDescription: "Remote connection UUID",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure, but I think connection_uuid value is UUID of "remote cluster". We add this to description, so user knows where to get this UUID (if you search for connection resource - we do not have it). But we will have resource hypercore_remote_cluster , you already suggested this (ty).

@justinc1 justinc1 force-pushed the hypercore_vm_replication branch from 2679745 to 453e817 Compare April 2, 2025 08:57
@justinc1 justinc1 merged commit 16fae8c into main Apr 2, 2025
8 of 9 checks passed
@justinc1 justinc1 deleted the hypercore_vm_replication branch April 2, 2025 09:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants