Skip to content

node data source #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 28, 2025
Merged

node data source #18

merged 4 commits into from
Mar 28, 2025

Conversation

justinc1
Copy link
Collaborator

PR :

  • adds hypercode_node data source
  • adds node affinity to hypercore_vm resource. It is optional, if omitted in main.tf the defaults are used.
  • adds node affinity also to hypercore_vm data source

@justinc1 justinc1 requested a review from anazobec March 26, 2025 14:25
@justinc1
Add hypercore_node data source
358f56e 
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
anazobec
anazobec approved these changes Mar 27, 2025
View reviewed changes
Copy link
Collaborator

@anazobec anazobec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @justinc1! 👍

You may merge when ready. Might be good to run make fmt lint first if not already.

justinc1 added 2 commits March 28, 2025 12:12
@justinc1
Add node affinity to VM
dffe1d8 
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
@justinc1
Add affinity_strategy to VM data source
c996757 
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
@justinc1
Add docs related to affinity_strategy
5edda98 
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
@justinc1 justinc1 merged commit 1e3299f into main Mar 28, 2025
6 checks passed
@justinc1 justinc1 deleted the node_data_source branch March 28, 2025 12:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anazobec anazobec anazobec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinc1 @anazobec