Skip to content

Implement hypercore_vm_snapshot #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2025
Merged

Implement hypercore_vm_snapshot #16

merged 3 commits into from
Apr 2, 2025

Conversation

anazobec
Copy link
Collaborator

@anazobec anazobec commented Mar 24, 2025

Closes #14

This MR implements the hypercore_vm_snapshot and other things needed for snapshot.

With resource hypercore_vm_snapshot, a user can create a USER type snapshot for a source VM by providing a VM UUID.

With resource hypercore_vm_snapshot_schedule, a user can create a schedule for automated snapshotting. The schedule can be applied to the created VM using the hypercore_vm reousrce with the added parameter: snapshot_schedule_uuid.

I also modified the VM data source, to also include data about the VMs' snapshot_schedule_uuid.

For more info, check the regenerated docs:

@anazobec anazobec requested a review from justinc1 March 24, 2025 15:27
@anazobec anazobec self-assigned this Mar 24, 2025
Copy link
Collaborator

@justinc1 justinc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes suggested.

@anazobec anazobec force-pushed the hypercore_vm_snapshot branch 2 times, most recently from 7db61bc to efa7e13 Compare March 26, 2025 22:37
@anazobec anazobec requested a review from justinc1 March 26, 2025 22:38
@anazobec anazobec force-pushed the hypercore_vm_snapshot branch 3 times, most recently from 5876076 to 8db1c4d Compare March 27, 2025 12:28
Copy link
Collaborator

@justinc1 justinc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should extend hypercore_vm resource with snapshot_schedule_uuid attribute, and drop vm_uuid_list attribute from hypercore_vm_snapshot_schedule resource. This will make implementation much simpler - do you agree?

@anazobec anazobec force-pushed the hypercore_vm_snapshot branch from 8db1c4d to 041443e Compare March 31, 2025 07:14
@anazobec anazobec requested a review from justinc1 March 31, 2025 07:15
@anazobec anazobec force-pushed the hypercore_vm_snapshot branch from 041443e to a2a10c3 Compare March 31, 2025 08:52
Copy link
Collaborator

@justinc1 justinc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty. Just some functions are unused, I suggest to remove them.

@anazobec anazobec force-pushed the hypercore_vm_snapshot branch 4 times, most recently from 826f1f0 to ce39f49 Compare April 1, 2025 09:12
@anazobec anazobec force-pushed the hypercore_vm_snapshot branch from ce39f49 to b19d83f Compare April 1, 2025 09:14
@anazobec anazobec requested a review from justinc1 April 1, 2025 09:17
Copy link
Collaborator

@justinc1 justinc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY and OK

@justinc1 justinc1 merged commit 9650ab7 into main Apr 2, 2025
6 checks passed
@justinc1 justinc1 deleted the hypercore_vm_snapshot branch April 2, 2025 07:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement hypercore_vm_snapshot
2 participants