-
Notifications
You must be signed in to change notification settings - Fork 3
Implement hypercore_vm_snapshot #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes suggested.
7db61bc
to
efa7e13
Compare
5876076
to
8db1c4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should extend hypercore_vm
resource with snapshot_schedule_uuid
attribute, and drop vm_uuid_list
attribute from hypercore_vm_snapshot_schedule
resource. This will make implementation much simpler - do you agree?
8db1c4d
to
041443e
Compare
041443e
to
a2a10c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ty. Just some functions are unused, I suggest to remove them.
826f1f0
to
ce39f49
Compare
Regenerate documentation
ce39f49
to
b19d83f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TY and OK
Closes #14
This MR implements the
hypercore_vm_snapshot
and other things needed for snapshot.With resource
hypercore_vm_snapshot
, a user can create aUSER
type snapshot for a source VM by providing a VM UUID.With resource
hypercore_vm_snapshot_schedule
, a user can create a schedule for automated snapshotting. The schedule can be applied to the created VM using thehypercore_vm
reousrce with the added parameter:snapshot_schedule_uuid
.I also modified the VM data source, to also include data about the VMs'
snapshot_schedule_uuid
.For more info, check the regenerated docs: