Skip to content

ISO attach logic #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 25, 2025
Merged

ISO attach logic #15

merged 3 commits into from
Mar 25, 2025

Conversation

domendobnikar
Copy link
Collaborator

  • added attach example to the ISO resource example file
  • added attach logic to disk_resource file to account for ISO - IDE_CDROM combination
  • added ISO validation logic to the vm_disk util file

closes #8

@domendobnikar
Implemented ISO attach logic
93901f8 
- added attach example to the ISO resource example file
- added attach logic to disk_resource file to account for ISO - IDE_CDROM combination
- added ISO validation logic to the vm_disk util file
@domendobnikar
documentation updates
18e9f75
@domendobnikar domendobnikar requested a review from justinc1 March 21, 2025 14:24
@domendobnikar domendobnikar changed the title Implemented ISO attach logic ISO attach logic Mar 21, 2025
@domendobnikar domendobnikar mentioned this pull request Mar 21, 2025
Closed
@domendobnikar domendobnikar requested a review from anazobec March 21, 2025 14:31
justinc1
justinc1 approved these changes Mar 24, 2025
View reviewed changes
Copy link
Collaborator

@justinc1 justinc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only one minor comment - one part of code seems dead to me.

@domendobnikar domendobnikar merged commit 9141d4c into ScaleComputing:main Mar 25, 2025
2 of 3 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@justinc1 justinc1 justinc1 approved these changes

@anazobec anazobec Awaiting requested review from anazobec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implementation of ISO Attach/upload
2 participants
@domendobnikar @justinc1