Skip to content

Conversation

siddu017
Copy link
Contributor

This PR fixes a NullPointerException that could occur if the download process failed to start.
The method now safely checks if the process was successfully created before attempting to read its output or wait for completion.

Fixes #959

Copy link

vercel bot commented Jul 30, 2025

@siddu017 is attempting to deploy a commit to the Saptarshi Sarkar's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Jul 30, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the App 💻 Issues/Pull Requests which update Drifty Application Code label Jul 30, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! You did it 🎉 Now, Relax 😉, Grab a drink ☕, and wait for the maintainers to check your contributions. Meanwhile, you can discuss on other issues and solve them 😀. Thank You 😃!

Meanwhile you can also discuss about the project in our Discord Server 😀

@github-actions github-actions bot added CI/CD 🔁 Pull Requests which update GitHub Actions code dependencies 📦️ Pull Requests that update dependencies labels Jul 30, 2025
siddu017 and others added 5 commits July 31, 2025 00:22
… filedownloader(SaptarshiSarkar12#8)

Signed-off-by: siddu017 <siddu22522@gmail.com>
Signed-off-by: siddu017 <siddu22522@gmail.com>
Signed-off-by: siddu017 <siddu22522@gmail.com>
Signed-off-by: siddu017 <siddu22522@gmail.com>
Signed-off-by: siddu017 <siddu22522@gmail.com>
@siddu017
Copy link
Contributor Author

@SaptarshiSarkar12 The PR is ready. Vercel deployment is pending authorization. Please review and approve when you get a chance. Thanks!

Copy link

vercel bot commented Jul 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drifty ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2025 5:09pm

@SaptarshiSarkar12
Copy link
Owner

@siddu017 Thank you for the quick fix 😁.
I have approved the Vercel deployment and I'll review it soon.

@SaptarshiSarkar12 SaptarshiSarkar12 added the bug 🐛 Issues/Pull Requests reporting/fixing a bug label Jul 31, 2025
Copy link
Owner

@SaptarshiSarkar12 SaptarshiSarkar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siddu017 Thank you for the great work! 👏
I’ve reviewed your PR. Could you please address the requested changes?

Signed-off-by: siddu017 <siddu22522@gmail.com>
…p.ini file

Signed-off-by: siddu017 <siddu22522@gmail.com>
@siddu017
Copy link
Contributor Author

@SaptarshiSarkar12 addressed and resolved the requested changes

Copy link
Owner

@SaptarshiSarkar12 SaptarshiSarkar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siddu017 Looks good to merge 👍.
Thanks for contributing 🚀 🚀.
You may join our Discord server - https://discord.gg/DeT4jXPfkG to get updates about the project.

@SaptarshiSarkar12 SaptarshiSarkar12 merged commit 7f845c9 into SaptarshiSarkar12:master Jul 31, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

App 💻 Issues/Pull Requests which update Drifty Application Code bug 🐛 Issues/Pull Requests reporting/fixing a bug CI/CD 🔁 Pull Requests which update GitHub Actions code dependencies 📦️ Pull Requests that update dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] NULL POINTER EXCEPTION IN FILEDOWNLOADER

2 participants