Protocol: Fix some packets #331
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Happy2018new
changed the title
packet.UpdateSubChunkBlocks
Co-Authored-By: Liliya233 <79683806+Liliya233@users.noreply.github.com>
…ntity` Co-Authored-By: Liliya233 <79683806+Liliya233@users.noreply.github.com>
Co-Authored-By: Liliya233 <79683806+Liliya233@users.noreply.github.com>
Co-Authored-By: Liliya233 <79683806+Liliya233@users.noreply.github.com>
Co-Authored-By: Liliya233 <79683806+Liliya233@users.noreply.github.com>
Co-Authored-By: Liliya233 <79683806+Liliya233@users.noreply.github.com>
…ionType` Co-Authored-By: Liliya233 <79683806+Liliya233@users.noreply.github.com>
Co-Authored-By: Liliya233 <79683806+Liliya233@users.noreply.github.com>
Co-Authored-By: Liliya233 <79683806+Liliya233@users.noreply.github.com>
Co-Authored-By: Liliya233 <79683806+Liliya233@users.noreply.github.com>
Co-Authored-By: Liliya233 <79683806+Liliya233@users.noreply.github.com>
|
All right, and ready for review. |
|
Most changes are come from @CoozillaX, and I just compare these changes with documents which wrote by Mojang. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fix so many packets (the data type for some fields), and the following is the reference list.
See UpdateSubChunkBlocks, and you can find that the data type for
Positionisprotocol.BlockPoswhich encoding byio.UBlockPos.See PlayerAuthInput and PackedItemUseLegacyInventoryTransaction, and you can find that the correct marshal for field
BlockPositionisio.UBlockPos.See AddVolumeEntity, RemoveVolumeEntity and EntityNetId, and you can find that the data type for
EntityRuntimeIDisuint32whcih encoding byio.Varuint32.See AgentActionEvent and int, and you can find that the data type for
Actionisint32which encoding byio.Int32.See ChangeMobProperty and ActorUniqueID, and you can find that the data type for
EntityUniqueIDisint64which encoding byio.Varint64.See CommandBlockUpdate, and you can find that the data type for
TickDelayisuint32 (unsigned int)which encoding byio.Uint32.See LessonProgress, and you can find that the data type for
Actionisint32which encoding byio.Varint32.See OnScreenTextureAnimation, and you can find that the data type for
AnimationTypeisuint32 (unsigned int)which encoding byio.Uint32.See RequestChunkRadius, and you can find that the data type for
MaxChunkRadiusisbytewhich encoding byio.Uint8.See RequestPermissions, and you can find that the data type for
PermissionLevelisint32which encoding byio.Varint32.See SimpleEvent, and you can find that the data type for
EventTypeisuint16 (unsigned short)which encoding byio.Uint16.See StartGame which path is
StartGamePacket/Settings (LevelSettings)and LevelSettings which path isLevelSettings/override force experimental gameplay has value, and you can find that the data type forForceExperimentalGameplayisboolwhich encoding byio.Bool.