Update the redis .multi code to remove the warnings in the logs #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noodl
previously approved these changes
Oct 17, 2024
….4 - but versions prior to 2.5 will use an implementation that will fail the rspecs
noodl
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.sage.com/browse/ENG-2692
As per the warnings we're now passing a parameter into the block that should be used instead of calling the redis client.
https://github.com/redis/redis-rb/blob/08f3e18db95ab4f3980d35a22f16904b53bb505d/README.md#executing-commands-atomically
Upgraded the ruby version to 3.2, and added a matrix of ruby versions 3.0 - 3.2 to the rspecs.
This version now locks minimum ruby version to 3.0 and above