-
Notifications
You must be signed in to change notification settings - Fork 4
Add Matroschka processing. #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Matroschka processing. #23
Conversation
…urrent code. Revert all of this with offset-based reading later. Also added unnecessary casting in wrapperfactory so serialization will build locally. Revert this, since I assume it somehow builds fine for GA/sabre/etc.
PR is ready for review. PR no longer relies on updating models, although in the future I can clean up some things when models is dumped. Responses to pointers you gave me in discord:
I apologize for however many I've missed, but I went through the things you told me to look for there and caught the ones I noticed
All non-todo comments seem ok to me after a pass
I think I've caught all these
Every remaining TODO (save for maybe 1 or 2) is a personal comment, because it's me wanting confirmation or otherwise from you. Assume every TODO I've left is asking you something, unless it really seems like it isn't. Otherwise, there shouldn't be any other personal comments
There's probably some naming issues, but I wouldn't be able to determine them on my own.
My current access levels definitely don't make sense. I hate to do this, but this is probably singlehandedly my greatest weakness in terms of programming; every time I make something private or static it winds up completely destroying my program, and every fix feels awful. I'll need your advice on what publics can be made private and what non-statics can be made static upon your review
I think I'm using everything I can that I should, but let me know if you see any areas where some more extensions would be useful.
I think I've done this
Just went through and did this.
Just went and did that.
Did that
Did that
It's currently in the Sections region; let me know if I can move it to the extension properties section or not. |
SabreTools.Serialization/Deserializers/SecuROMMatroschkaPackage.cs
Outdated
Show resolved
Hide resolved
SabreTools.Serialization/Deserializers/SecuROMMatroschkaPackage.cs
Outdated
Show resolved
Hide resolved
SabreTools.Serialization/Deserializers/SecuROMMatroschkaPackage.cs
Outdated
Show resolved
Hide resolved
SabreTools.Serialization/Deserializers/SecuROMMatroschkaPackage.cs
Outdated
Show resolved
Hide resolved
SabreTools.Serialization/Wrappers/SecuROMMatroschkaPackage.Extraction.cs
Outdated
Show resolved
Hide resolved
SabreTools.Serialization/Wrappers/SecuROMMatroschkaPackage.Extraction.cs
Outdated
Show resolved
Hide resolved
SabreTools.Serialization/Wrappers/SecuROMMatroschkaPackage.Extraction.cs
Outdated
Show resolved
Hide resolved
|
||
#endregion | ||
|
||
#region Constructors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll handle the changes to the constructor layout and such after this gets merged.
PR relies on updating models due to SabreTools/SabreTools.Models@978b690 .
PR is marked as a draft for the moment until I can: