[WIP] Add 7-Zip SFX extraction #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newest SharpCompress added support for extracting 7-Zip SFX files, so we can add support for them here too.
mnadareski
reviewed
Sep 25, 2024
mnadareski
reviewed
Sep 25, 2024
mnadareski
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newest SharpCompress added support for extracting 7-Zip SFX files, so we can add support for them here too.
Relies on #320, or SharpCompress being updated to 0.38.0 otherwise. There appears to be a bug present where files in a folder inside of 7z archives aren't extracted, but this occurs with normal 7z archives in latest release as well and will be reported separately. So, this has been marked as "[WIP]" in-case changes need to be made to the extraction code in SFX as well. Alternatively, this can be merged and then the bug can be dealt with at a later time.