-
Notifications
You must be signed in to change notification settings - Fork 0
No conversion when delimiter occurs elsewhere too #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sungshik
merged 15 commits into
main
from
no-conversion-when-delimiter-occurs-elsewhere-too
Sep 23, 2024
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
221eb84
Add utility type/function to find a kind of pointer (production-index…
sungshik 7b1d2b6
Add mechanism to skip conversion of productions when their begin deli…
sungshik a0f2431
Update tests
sungshik a83bb79
Update generated TextMate grammar for Rascal/Pico
sungshik f88b953
Merge branch 'main' into no-conversion-when-delimiter-occurs-elsewher…
sungshik a5be71d
Fix typo and revert unneeded change
sungshik 7cefa0a
Fix issue in the definition of delimiters (not only word chars vs. on…
sungshik 9e4a229
Fix an issue that guards (look-behind condition to match layouts) wer…
sungshik 6106209
Update generated TextMate grammar for Rascal/Pico
sungshik 823dbab
Add empty test input files for remaining test modules
sungshik 7ce634b
Fix issue with shell executions of tokenization tests
sungshik 5b9abd1
Fix issue with shell executions differently
sungshik 53fe327
Add comment and remove old code related to issue with shell executions
sungshik c4b28fb
Rewrite `isDelimiter` and `isKeyword` for CI literals (in terms of no…
sungshik 416bc7d
Improve comments
sungshik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
rascal-textmate-core/src/main/rascal/lang/textmate/conversiontests/Rascal.test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
# SYNTAX TEST "Rascal" | ||
|
||
"foo bar" | ||
# ^^^^^^^^^ Constant | ||
|
||
"foo<x + 1>bar" | ||
# ^^^^^ ^^^^^ Constant | ||
# ^^^^^ -Constant | ||
|
||
### TODO: The following test shows that, currently, multi-line strings are | ||
### disabled. This is because the converter determines that: | ||
### - `>` doesn't uniquely delineate interpolation (it could also be | ||
### greater-than in expressions or prioritize-before in grammars); | ||
### - `"` doesn't uniquely delineate strings (it could also be the end of | ||
### interpolation). | ||
### Therefore, to avoid excessive tokenization errors, the converter doesn't | ||
### generate begin/end patterns that begin with `>` or `"`. This might be | ||
### improved in the future. | ||
|
||
"foo | ||
# ^^^^ -Constant | ||
bar" | ||
# ^^^^ -Constant |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
rascal-textmate-core/src/main/rascal/lang/textmate/conversiontests/RascalClass.test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
# SYNTAX TEST "RascalClass" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
rascal-textmate-core/src/main/rascal/lang/textmate/conversiontests/RascalConcrete.test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
# SYNTAX TEST "RascalConcrete" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
rascal-textmate-core/src/main/rascal/lang/textmate/conversiontests/Walkthrough.test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
# SYNTAX TEST "Walkthrough" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.