-
Notifications
You must be signed in to change notification settings - Fork 0
Pico VS Code extension #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… extension) with explicit keywords
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few review comments
the special VS Code extension | ||
} | ||
|
||
module VSCodeRascal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is essentially a rename of the old VSCode
module:
- Function
main
was a bit streamlined - Function
getRscGrammar
is identical to before
@@ -42,10 +42,22 @@ syntax Expression | |||
| min: Expression lhs "-" Expression rhs) | |||
; | |||
|
|||
lexical Id = [a-z][a-z0-9]* !>> [a-z0-9]; | |||
lexical Id = ([a-z][a-z0-9]*) !>> [a-z0-9] \ Keyword; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this condition (diverging slightly from lang::pico::\syntax::Main
) to make the highlighting a bit nicer)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
This PR extends the syntax-highlighting-only VS Code extension (with generated TextMate grammars) with support for Pico (in addition to Rascal). To this end, this PR:
Note: None of the actual conversion code is affected.