[LAB4] 511558025

.github/workflows/PR.yml

@@ -15,27 +15,31 @@ jobs:
                       const { owner, repo, number: issue_number } = context.issue;
                       const pr = await github.rest.pulls.get({ owner, repo, pull_number: issue_number });
                       const title = pr.data.title;
-                      const labRegex = /\[LAB(\d+)\]/;
-                      const titleRegex = /^\[LAB\d+\] [\da-zA-Z]+$/;
 
-                      if (!titleRegex.test(title)) {
-                        core.setFailed('PR title does not match the required format. Please use the format [LAB#] student#.');
+                      const titleRegex = /^\[LAB(\d+)\] [a-zA-Z]?\d+$/;
+                      const match = title.match(titleRegex);
+
+                      let labNumberStr = undefined;
+                      if (match) {
+                        labNumberStr = match[1];
+                      } else {
+                        core.setFailed('PR title does not match the required format. Please use the format: [LAB#] <studentId>.');
                       }
 
-                      if (pr.data.head.ref !== pr.data.base.ref) {
-                        core.setFailed('The source branch and target branch must be the same.');
+                      const labelToAdd = `lab${labNumberStr}`;
+                      if (labNumberStr) {
+                        await github.rest.issues.addLabels({ owner, repo, issue_number, labels: [labelToAdd] });
                       }
 
                       if (pr.data.base.ref === 'main') {
                         core.setFailed('The target branch cannot be main.');
                       }
 
-                      const match = title.match(labRegex);
-                      if (match) {
-                        const labelToAdd = 'lab' + match[1];
-                        await github.rest.issues.addLabels({ owner, repo, issue_number, labels: [labelToAdd] });
-                      } else {
-                        core.setFailed('No match found in PR title. Please add a label in the format [LAB#] to the PR title.');
+                      if (labNumberStr < 3 && pr.data.head.ref !== pr.data.base.ref) {
+                        core.setFailed('The source branch and target branch must be the same.');
+                      }
+                      if (labNumberStr >= 3 && pr.data.head.ref !== labelToAdd) {
+                        core.setFailed(`The source branch must be '${labelToAdd}'`);
                       }
     checklist-check:
         runs-on: ubuntu-latest
@@ -49,12 +53,12 @@ jobs:
                       const pr = await github.rest.pulls.get({ owner, repo, pull_number: issue_number });
                       const body = pr.data.body;
 
-                      const checkboxes = body.match(/\- \[[x ]\]/g);
+                      const checkboxes = body.match(/^ ?(-|\*) \[[x ]\]/gmi);
                       if (!checkboxes || checkboxes.length !== 5) {
                         core.setFailed('The PR description must contain exactly 5 checkboxes.');
                       }
 
-                      const unchecked = body.match(/\- \[ \]/g);
+                      const unchecked = body.match(/^ ?(-|\*) \[ \]/gm);
                       if (unchecked && unchecked.length > 0) {
-                        core.setFailed(`There are ${unchecked.length} unchecked items in the PR description.`);
+                        core.setFailed(`There are ${unchecked.length} unchecked item(s) in the PR description.`);
                       }

.github/workflows/lab-autograding.yml

@@ -0,0 +1,56 @@
+name: Autograding
+
+on:
+    pull_request_target:
+        types: [labeled, synchronize, opened, reopened, ready_for_review]
+
+jobs:
+    build:
+        runs-on: ${{ matrix.os }}
+        strategy:
+            matrix:
+                os: [ubuntu-22.04]
+            fail-fast: false
+        steps:
+            - uses: actions/checkout@v4
+              with:
+                  ref: "${{ github.event.pull_request.merge_commit_sha }}"
+                  fetch-depth: 1
+            - uses: actions/setup-node@v4
+              with:
+                  node-version: latest
+            - name: Extract lab number and Check no changes other than specific files
+              uses: actions/github-script@v5
+              id: lab
+              with:
+                  result-encoding: string
+                  github-token: ${{ secrets.GITHUB_TOKEN }}
+                  script: |
+                      const { owner, repo, number: issue_number } = context.issue;
+                      const pr = await github.rest.pulls.get({ owner, repo, pull_number: issue_number });
+                      const labels = pr.data.labels;
+                      const lab = labels.find((label) => label.name.startsWith('lab'));
+                      if (!lab) {
+                        core.setFailed('No lab label found on the PR.');
+                        return { number: 0 };
+                      }
+                      const labNumberMatch = lab.name.match(/lab(\d+)/);
+                      if (!labNumberMatch) {
+                        core.setFailed('Invalid lab label found on the PR.');
+                        return { number: 0 };
+                      }
+                      const labNumber = labNumberMatch[1];
+                      console.log(`Lab number: ${labNumber}`)
+
+                      const files = await github.rest.pulls.listFiles({ owner, repo, pull_number: issue_number });
+                      const changedFiles = files.data.map((file) => file.filename);
+                      const allowedFileRegex = /^lab\d+\/main_test.js$/;
+                      const specialChangedFiles = ["lab5/Answer.md", "lab5/antiasan.c", "lab6/Answer.md", "lab7/sol.py"];
+                      if (!changedFiles.every((file) => (allowedFileRegex.test(file) || specialChangedFiles.includes(file)))) {
+                        core.setFailed('The PR contains changes to files other than the allowed files.');
+                      }
+                      return labNumber;
+            - name: Grading
+              run: |
+                  cd lab${{ steps.lab.outputs.result }}
+                  ./validate.sh

.gitignore

@@ -0,0 +1 @@
+node_modules/

lab1/main_test.js

@@ -3,21 +3,60 @@ const assert = require('assert');
 const { MyClass, Student } = require('./main');
 
 test("Test MyClass's addStudent", () => {
-    // TODO
-    throw new Error("Test not implemented");
+  const myClass = new MyClass();
+  //create 2 students John & Jane
+  const student1 = new Student();
+  student1.setName('John');
+  const id1 = myClass.addStudent(student1);
+  assert.strictEqual(id1, 0);
+
+  const student2 = new Student();
+  student2.setName('Jane');
+  const id2 = myClass.addStudent(student2);
+  assert.strictEqual(id2, 1);
+
+  //新增一個TESTING student
+  const invalidStudent = 'TESTING';
+  const invalidId = myClass.addStudent(invalidStudent);
+  assert.strictEqual(invalidId, -1);
+
 });
 
 test("Test MyClass's getStudentById", () => {
-    // TODO
-    throw new Error("Test not implemented");
+  const myClass = new MyClass();
+  const student1 = new Student();
+  student1.setName('John');
+  myClass.addStudent(student1);
+
+  const retrievedStudent = myClass.getStudentById(0);
+  assert.strictEqual(retrievedStudent.getName(), 'John');
+
+  const invalidStudent = myClass.getStudentById(-1);
+  assert.strictEqual(invalidStudent, null);
+
+  const outOfBoundsStudent = myClass.getStudentById(1);
+  assert.strictEqual(outOfBoundsStudent, null);
+
 });
 
 test("Test Student's setName", () => {
-    // TODO
-    throw new Error("Test not implemented");
+  const student = new Student();
+  //測試變數是否有效
+  student.setName('Alice');
+  assert.strictEqual(student.getName(), 'Alice');
+
+  student.setName(123); 
+  assert.strictEqual(student.getName(), 'Alice');
+
 });
 
 test("Test Student's getName", () => {
-    // TODO
-    throw new Error("Test not implemented");
-});
+  const student = new Student();
+  // 初始化未設置
+  assert.strictEqual(student.getName(), '');
+
+  // 設置變數後返回
+  student.setName('Bob');
+  assert.strictEqual(student.getName(), 'Bob');
+
+});

lab2/main_test.js

@@ -1,6 +1,64 @@
-const test = require('node:test');
+const testUtil = require('node:test');
 const assert = require('assert');
+const fs = require('fs');
+
+// Mock the file containing names
+testUtil.mock.method(fs, 'readFile', (file, options, callback) => {
+    callback(null, 'Alice\nBob\ncat');
+});
+
 const { Application, MailSystem } = require('./main');
 
-// TODO: write your tests here
-// Remember to use Stub, Mock, and Spy when necessary
+testUtil('MailSystem_write()', () => {
+    const mailSystem = new MailSystem();
+    assert.strictEqual(mailSystem.write('Alice'), 'Congrats, Alice!');
+    assert.strictEqual(mailSystem.write(202), 'Congrats, 202!');
+    assert.strictEqual(mailSystem.write(null), 'Congrats, null!');
+});
+
+testUtil('MailSystem_send()', () => {
+    const mailSystem = new MailSystem();
+    const name = 'Alice';
+    testUtil.mock.method(Math, 'random', () => 0.9);
+    assert.strictEqual(mailSystem.send(name, 'success'), true);
+    testUtil.mock.method(Math, 'random', () => 0.2);
+    assert.strictEqual(mailSystem.send(name, 'fail'), false);
+});
+
+testUtil('Application_getNames()', async () => {
+    const app = new Application();
+    const nameList = ['Alice', 'Bob', 'cat'];
+    const [names, selected] = await app.getNames();
+    assert.deepStrictEqual(names, nameList);
+    assert.deepStrictEqual(selected, []);
+});
+
+testUtil('Application_getRandomPerson()', async () => {
+    const app = new Application();
+    const [names] = await app.getNames();                          
+    const randomPerson = app.getRandomPerson();
+});
+
+testUtil('Application_selectNextPerson()', async () => {
+    const app = new Application();
+    const [names] = await app.getNames();
+    app.selected = ['Alice'];
+    let count = 0;
+    testUtil.mock.method(app, 'getRandomPerson', () => names[count++]);
+    assert.strictEqual(app.selectNextPerson(), 'Bob');
+    assert.deepStrictEqual(app.selected, ['Alice', 'Bob']);
+    assert.strictEqual(app.selectNextPerson(), 'cat');
+    assert.deepStrictEqual(app.selected, ['Alice', 'Bob', 'cat']);
+    assert.strictEqual(app.selectNextPerson(), null);
+});
+
+testUtil('Application_notifySelected()', async () => {
+    const app = new Application();
+    const [names] = await app.getNames();
+    app.selected = names.slice(); // Select all names initially
+    app.mailSystem.send = testUtil.mock.fn(app.mailSystem.send);
+    app.mailSystem.write = testUtil.mock.fn(app.mailSystem.write);
+    app.notifySelected();
+    assert.strictEqual(app.mailSystem.send.mock.calls.length, names.length);
+    assert.strictEqual(app.mailSystem.write.mock.calls.length, names.length);
+});

lab3/README.md

@@ -0,0 +1,31 @@
+# Lab3
+
+## Introduction
+
+In this lab, you will write unit tests for functions implemented in `main.js`. You can learn how to use classes and functions in it by uncommenting the code in it. (But remember don't commit them on GitHub)
+
+## Preparation (Important!!!)
+
+1. Sync fork your branch (e.g., `SQLab:311XXXXXX`)
+2. `git checkout 311XXXXXX`
+3. `git pull`
+4. `git checkout -b lab3` (**NOT** your student ID !!!)
+
+## Requirement
+
+1. (40%) Write test cases in `main_test.js` and achieve 100% code coverage.
+2. (30%) For each function, parameterize its testcases to test the error-results.
+3. (30%) For each function, use at least 3 parameterized testcases to test the non-error-results.
+
+You can run `validate.sh` in your local to test if you satisfy the requirements.
+
+Please note that you must not alter files other than `main_test.js`. You will get 0 points if
+
+1. you modify other files to achieve requirements.
+2. you can't pass all CI on your PR.
+
+## Submission
+
+You need to open a pull request to your branch (e.g. 311XXXXXX, your student number) and contain the code that satisfies the abovementioned requirements.
+
+Moreover, please submit the URL of your PR to E3. Your submission will only be accepted when you present at both places.

lab3/main.js

@@ -0,0 +1,34 @@
+class Calculator {
+    exp(x) {
+        if (!Number.isFinite(x)) {
+            throw Error('unsupported operand type');
+        }
+        const result = Math.exp(x);
+        if (result === Infinity) {
+            throw Error('overflow');
+        }
+        return result;
+    }
+
+    log(x) {
+        if (!Number.isFinite(x)) {
+            throw Error('unsupported operand type');
+        }
+        const result = Math.log(x);
+        if (result === -Infinity) {
+            throw Error('math domain error (1)');
+        }
+        if (Number.isNaN(result)) {
+            throw Error('math domain error (2)');
+        }
+        return result;
+    }
+}
+
+// const calculator = new Calculator();
+// console.log(calculator.exp(87));
+// console.log(calculator.log(48763));
+
+module.exports = {
+    Calculator
+};