Skip to content

fix hostAliases; lost 'ports' key #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
## Changelog

### V2.2.1

#### Non-Breaking Changes

- Correct issues in deployment when `rconAPI` and `port_fixer` are used simultaniously.
- Add missing `ports` key to rconAPI container

### V2.2.0

#### Non-Breaking Changes
Expand Down
2 changes: 1 addition & 1 deletion charts/factorio-server-charts/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ sources:
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 2.2.0
version: 2.2.1

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
57 changes: 29 additions & 28 deletions charts/factorio-server-charts/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,35 @@ spec:
value: {{ .Values.factorioServer.port | quote }}
- name: RCON_PORT
value: {{ .Values.factorioServer.rcon_port | quote }}
{{- if .Values.rconAPI.enabled }}
- name: {{ template "factorio-server-charts.fullname" . }}-rcon-api
image: "{{ .Values.rconAPI.image.repository }}:{{ .Values.rconAPI.image.tag }}"
imagePullPolicy: {{ .Values.rconAPI.image.pullPolicy }}
livenessProbe:
httpGet:
path: /healthz
port: rcon-api
ports:
- name: rcon-api
containerPort: 24180
protocol: TCP
- containerPort: 24181
protocol: TCP
env:
- name: FACTORIO_RCON_HOST
value: "localhost"
- name: FACTORIO_RCON_PORT
value: {{ .Values.factorioServer.rcon_port | quote }}
- name: FACTORIO_RCON_PASSWORD
{{- if .Values.rcon.passwordSecret }}
valueFrom:
secretKeyRef:
name: {{ .Values.rcon.passwordSecret }}
key: rconpw
{{- else }}
value: {{ .Values.rcon.password | quote }}
{{- end }}
{{- end }}
{{- if .Values.port_fixer.enabled }}
- name: {{ template "factorio-server-charts.fullname" . }}-port-fixer
image: "{{ .Values.port_fixer.image.repository }}:{{ .Values.port_fixer.image.tag }}"
Expand Down Expand Up @@ -208,34 +237,6 @@ spec:
- pingpong3.factorio.com
- pingpong4.factorio.com
{{- end }}
{{- if .Values.rconAPI.enabled }}
- name: {{ template "factorio-server-charts.fullname" . }}-rcon-api
image: "{{ .Values.rconAPI.image.repository }}:{{ .Values.rconAPI.image.tag }}"
imagePullPolicy: {{ .Values.rconAPI.image.pullPolicy }}
livenessProbe:
httpGet:
path: /healthz
port: rcon-api
- name: rcon-api
containerPort: 24180
protocol: TCP
- containerPort: 24181
protocol: TCP
env:
- name: FACTORIO_RCON_HOST
value: "localhost"
- name: FACTORIO_RCON_PORT
value: {{ .Values.factorioServer.rcon_port | quote }}
- name: FACTORIO_RCON_PASSWORD
{{- if .Values.rcon.passwordSecret }}
valueFrom:
secretKeyRef:
name: {{ .Values.rcon.passwordSecret }}
key: rconpw
{{- else }}
value: {{ .Values.rcon.password | quote }}
{{- end }}
{{- end }}
{{- if .Values.nodeSelector }}
nodeSelector:
{{ toYaml .Values.nodeSelector | indent 8 }}
Expand Down
Loading