Skip to content

add rcon-rest-api container #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 3, 2024
Merged

Conversation

Kariton
Copy link
Contributor

@Kariton Kariton commented Oct 28, 2024

nekomeowww/factorio-rcon-api

Fully implemented wrapper for Factorio headless server console as RESTful and gRPC for easier management through APIs

This is a fairly new project i discovered by chance.
hope you dont mind adding a additional (optional) container which adds so much value (or has the potential to do so).

some quick examples:

# curl -X GET https://factorio/api/v1/factorio/console/command/version
{"version":"2.0.11"}
# curl -X GET https://factorio/api/v1/factorio/console/command/seed
{"seed":"3508092348"}
# curl -X GET https://factorio/api/v1/factorio/console/command/players
{"players":[{"username":"Players","online":false},{"username":"MYNAME","online":true}]} # '{"username":"Players","online":false}' look bugged to me. i am alone; or am i?
# curl -X GET https://factorio/api/v1/factorio/console/command/evolution
{"evolutionFactor":0.0202,"time":100,"pollution":0,"spawnerKills":0}
# curl -X POST https://factorio/api/v1/factorio/console/command/server-save
{}
# curl -X POST https://factorio/api/v1/factorio/console/command/kick -d '{"username": "nicname","reason": "API Test"}'
{}

@Kariton Kariton requested a review from SQLJames as a code owner October 28, 2024 14:06
@Kariton
Copy link
Contributor Author

Kariton commented Oct 31, 2024

gonna add new livenessprobes later. /healthz is supported now.

@Kariton
Copy link
Contributor Author

Kariton commented Oct 31, 2024

same as in my other pr...

Error: Service "factorio-server-charts-qqm09zfbha-rcon" is invalid: spec.ports[0].targetPort: Invalid value: "27015": must contain at least one letter (a-z)

i dont even know what this is talking about. ^^
are we now an harbor? where ports have letters?

@Kariton
Copy link
Contributor Author

Kariton commented Oct 31, 2024

oi. quote

@Kariton
Copy link
Contributor Author

Kariton commented Oct 31, 2024

as known:

cli: execute: auth: rcon: dial tcp 10.96.122.250:30100: connect: connection refused

@SQLJames
Copy link
Owner

SQLJames commented Nov 3, 2024

@Kariton there are some conflicts due to the port fixer merge, do you want to update this and I'll begin QA on this as well?

@Kariton
Copy link
Contributor Author

Kariton commented Nov 3, 2024

hm. github merge resolver merges main onto PR branch.
should i rebase (and squash) instead?

@Kariton
Copy link
Contributor Author

Kariton commented Nov 3, 2024

i think disabling tls per default is better because it requires further configuration anyways.

Copy link
Owner

@SQLJames SQLJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about making the values rconAPI

@SQLJames
Copy link
Owner

SQLJames commented Nov 3, 2024

Also left comment for chart version

@SQLJames SQLJames merged commit d19bdfa into SQLJames:main Nov 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants