Add label support to the data-pvc #55
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Longhorn uses labels to find volumes to backup, plus having labels makes sense anyway Add values field for data-dir labels Add data-pvc labels field to README Bump Chart version number to 2.0.2
SQLJames
approved these changes
Oct 24, 2024
|
I was trying to fix the merge conflict and correct the version but I am getting an error for permissions on your branch |
|
@ohnoitsyou I opened PR #60 to get this merged in. Since the commit is missing from the chain I gave you a shout out in the change log |
|
Ah, hadn't realize there had been new commits. Thanks for getting it merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Longhorn uses labels to find volumes to backup, plus having labels makes sense anyway
Add values field for data-dir labels
Add data-pvc labels field to README