Skip to content

add container env 'DLC_SPACE_AGE' support #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

Kariton
Copy link
Contributor

@Kariton Kariton commented Oct 22, 2024

fixes #51

rebase / version bump follows when #50 is merged.

@Kariton Kariton requested a review from SQLJames as a code owner October 22, 2024 20:54
@Kariton
Copy link
Contributor Author

Kariton commented Oct 22, 2024

was unsure what you would prefer - the "technical" term or the "human" version.
e.g.: DLC_SPACE_AGE / enable_space_age

also updated the comments to match those from the container repo.

@Fank
Copy link

Fank commented Oct 22, 2024

I went for DLC_SPACE_AGE because the environment scope is quite limited for naming, and since its a DLC i went for DLC prefix.
But here i would recommend using enable as prefix, its easier to understand.

@SQLJames
Copy link
Owner

pending merger for #50 Because we will need to bump the chart version to 2.0.1 here.

@Kariton Kariton force-pushed the disable-space-age-option branch from 6d63ae8 to 18ca762 Compare October 23, 2024 10:19
@Kariton
Copy link
Contributor Author

Kariton commented Oct 23, 2024

lol.

this time my own run failed the first time.
second time worked...

https://github.com/Kariton/factorio-server-charts/actions/runs/11477874206/job/31941033773

@Kariton
Copy link
Contributor Author

Kariton commented Oct 23, 2024

something odd is happening with the GH workflow

@Kariton
Copy link
Contributor Author

Kariton commented Oct 23, 2024

your chart release GH token seems to be expired. ;)

@SQLJames SQLJames merged commit f60af0b into SQLJames:main Oct 23, 2024
2 checks passed
@SQLJames
Copy link
Owner

its fixed now and merged in, still getting weird instances of that rcon port but ill dig into that likely this weekend and maybe add more tests as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to disable Space Age DLC
3 participants