Skip to content

add compatibility for v2.0 #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

henryjarend
Copy link

adding in the asteroids section of map_settings to work with the docker image v2.0

Copy link
Owner

@SQLJames SQLJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@SQLJames
Copy link
Owner

Would you mind bumping the chart.yaml version to 2.0 and also adding to the change log?

@Kariton
Copy link
Contributor

Kariton commented Oct 22, 2024

while this might work there are more changes then just that.
https://github.com/SQLJames/factorio-server-charts/blob/98d5b4ceb83b38abccc8515ef560e61f9a4e96bf/charts/factorio-server-charts/values.yaml#L318-#L323

those for example. they no longer exist.

@henryjarend
Copy link
Author

Not sure which MR should get merged. I think that the MR from @Kariton is more feature rich so I'll go ahead and close this one out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants