-
Notifications
You must be signed in to change notification settings - Fork 0
[CFMS][HaiDang] Implement Google Maps #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hdang09
commented
May 4, 2025


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates several UI components and data tables across the application while introducing search functionality on category pages and renaming some components for clarity. Key changes include removal or commenting out of legacy code in column configurations, integration of TaskDialog across multiple data table actions, and layout/styling adjustments in authentication and category pages.
Reviewed Changes
Copilot reviewed 86 out of 88 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/(main)/config/columns.tsx | Commented-out legacy columns have been preserved; consider cleanup. |
| src/app/(main)/chicken-coop/[chickenCoopId]/components/task/columns.tsx | Updated task column to display task name instead of chicken coop name. |
| src/app/(main)/chicken-batch/[chickenBatchId]/page.tsx | Renamed vaccination log component and added task fetching to sessionStorage. |
| src/app/(main)/chicken-batch/**/components/* (vaccine, quantity, health, feed, etc.) | Introduced TaskDialog dialogs and adjusted dialog contents and column formats. |
| src/app/(main)/category/all/page.tsx & src/app/(main)/category/[categoryId]/page.tsx | Added search inputs to filter category and sub-category data. |
| src/app/(auth)/sign-up/page.tsx & src/app/(auth)/sign-in/page.tsx | Adjusted panel visibility and layout for improved responsiveness. |
Files not reviewed (2)
- .env: Language not supported
- package.json: Language not supported
| enableSorting: false, | ||
| enableHiding: false, | ||
| }, | ||
| // { |
Copilot
AI
May 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider removing or cleaning up commented-out code in this file if it is no longer needed to improve readability and maintainability.
src/app/(main)/chicken-batch/[chickenBatchId]/components/health/data-table-row-actions.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…S/CFMS-Frontend into feature/google-map