(devtool) installer text adjustment #441
Conversation
Electron/app/main.ts
Outdated
| let version = ''; | ||
| let WinTitle = translations['PAGES.HOME.TITLE']; | ||
| let WinTitle_err = ''; | ||
| fs.readFile(path.join(__dirname, 'package.json'), 'utf8', (err, data) => { |
There was a problem hiding this comment.
package.json is an internal src file, it won't be available in the release artifact.
There was a problem hiding this comment.
I asked AI about this and they said it's feasible. I suggested trying compiling it, but I didn't compile it locally...........
| @@ -9,8 +12,8 @@ | |||
| "INCLUDE_COMMANDER": "Install Commander", | |||
| "INCLUDE_COMMANDER_VSAI": "Vs Vanilla AI", | |||
| "INCLUDE_COMMANDER_OFF": "No Commander", | |||
| "OPTIMISE": "Use Optimised Scripts", | |||
| "FORCELANG": "Override Default AI Language" | |||
| "OPTIMISE": "Reduce System Load", | |||
There was a problem hiding this comment.
We should make an onhover tooltip rather than change the message here.
There was a problem hiding this comment.
Actually, no one may have read it, but I rely entirely on AI to consult a little bit on HTML adjustments, and the changes may not be as good as those made by professional engineers
like How to add a standard question mark icon after text, with a mouse move in button prompt
| @@ -207,6 +207,26 @@ const installOnDirectory = async () => { | |||
| process.send(f2AddToMPQ.error.message) | |||
| : process.send(installCommander ? `Installing commander ${file}` : `Installing VS Vanilla AI commander ${file}`); | |||
|
|
|||
| } else { | |||
| const f2AddToMPQ = spawnSync( | |||
| `MPQEditor.exe`, | |||
There was a problem hiding this comment.
This is dangerous, as uninstalling all the time could break maps that never installed the commander but do have a custom blizzard.j.
This needs to be an option or new menu options to run the uninstalls.
There was a problem hiding this comment.
There are a few buttons, it may be necessary to readjust the layout
|
How about this |
|
|
|
now can work |
Adjust the text, some feedback says they don't understand
Windows title displays the version number, but I haven't tested it
fix this