[pull] master from picodata:master #155
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
I fix clippy warnings
^
| T_T |
v
they add new ones
This is a continuation of work done in commit 52bb62c. This time the problem arose after a recent change in rustc, and resulted in lua exceptions stopping being intercepted by tarantool. I don't know yet what's the specific cause of this, what changed in rust and how did it affect the seemingly unrelated functionality of tarantool, but this change seems to help. Here's how the problem showcased in the tests: running 1 test test tlua::functions_write::error ... #1 0x16378a7 in tarantool_panic_handler+103 #2 0x183eaf5 in lj_err_throw+117 #3 0x183ee65 in lj_err_run+277 #4 0x183f63f in lua_error+15 #5 0x7673285fc50a in ??+0 #6 0x1834373 in lj_BC_FUNCC+70 #7 0x183b295 in lua_pcall+117 #8 0x76732868f87d in ??+0 #9 0x7673286adea5 in ??+0 #10 0x7673289e1acc in ??+0 #11 0x7673289e15ae in ??+0 #12 0x7673289e0f9c in ??+0 #13 0x7673289dedfb in ??+0 #14 0x7673289ced2c in ??+0 #15 0x76732858b414 in ??+0 #16 0x7673285a1659 in ??+0 #17 0x16920eb in module_func_call+139 #18 0x17b4ba3 in lbox_func_call+307 #19 0x1834373 in lj_BC_FUNCC+70 #20 0x183b295 in lua_pcall+117 #21 0x16411ef in luaT_call+15 #22 0x16381f1 in lua_main+97 #23 0x1638ab1 in run_script_f+2193 #24 0x165c3e1 in fiber_cxx_invoke(int (*)(__va_list_tag*), __va_list_tag*)+17 #25 0x15beea7 in fiber_loop+55 #26 0x1618f68 in coro_init+72 2025-02-10 19:39:05.410 [3087063] main/104/run_tests.lua C> your message: my message
Prior to version 2.11.5.225, the picodata fork of tarantool allowed preparing the same query multiple times in a single session via the custom C API. Beginning with 2.11.5.225, this is no longer supported. Therefore, we must clear the statement cache after each test.
In d52b8d6 we introduced a really weird soft deprecation for almost never used methods in `tarantool::tuple::Tuple` struct. The chosen deprecation strategy was erroneous and created a lot of ambiguous behavior for the users of it's public API. This commit makes them a little bit better: the error will be logged and method will panic. Closes #240. Follow-up for !579.
We want to be able to use new raw pointer syntax to clean up some warnings about potential unsafety in our code. This syntax was introduced in version 1.82, meanwhile we are on a 1.81 MSRV.
Just fixing some warnings about mutable static references from compiler with a macros that creates a reference on a raw pointer, fixing a warning from a Clippy about creating a reference on a raw pointer :D
In Picodata, there is a need to just hash data, without encoding (e.g. interoperation with Tarantool from Picoplugin SDK). This commit splits authentication functions into separate functions: hashing implementation and hashing with encoding. Close: none. Follow-up: picodata!1835.
BREAKING CHANGE!: the argument type in `lua_dump` has changed from `*mut LuaState` to `*mut lua_State`. The `lua_dump` signature was incorrectly implemented as `*mut LuaState` (i.e., ``*mut (*mut lua_State)`) instead of the required `*mut lua_State`. With the wrong signature, the method was non-functional, while picodata needs it to migrate the SQL executor to the new port API. Also add a convenience constructor for the virtual table and improve its test coverage.
…` with default generic parameters The implementation re-uses code from serde's `ImplGenerics` `ToTokens` impl, which already handle this correctly, but cannot be used in this macro.
… is found in picodata CI The mismatch is due to different versions of clippy used (0.1.82 vs 0.1.85)
…ndex::Part` This makes the types follow the api more closely, removes some error condition and makes it easier to implement column renaming
It was originally pinned for MSRV reasons, but right now `time` MSRV is well behind the MSRV in module (1.67.1 vs 1.82) This gets us two years of bug fixes, including a fix for picodata#1945
We had a few unmaintaned or archived dependencies in our workspace, or their versions were too old to continue their living in modern Rust. This commit introduces the following changes: * `dlopen` (`0.1.8`) -> `libloading` (`0.8`) * `linkme` (`0.3.29`) -> `linkme` (`0.3`) * `proc-macro-error` (`1`) -> `proc-macro-error2` (`2`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )