-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add in junit pioneer for testing #904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results 234 files ±0 234 suites ±0 8m 8s ⏱️ -8s Results for commit 8fa839f. ± Comparison against base commit aff1e01. This pull request removes 4 tests.
♻️ This comment has been updated with latest results. |
fix typo fix unused dependency version declaration
I want to discuss 2 further things, what's the goto for declaring version in
vs declaring it directly on the import
Kind of confusing why we have both. Would like to stick to one way or another. |
|
I don't know if there is a general rule on this, so I can only speak for myself: I prefer the direct approach for better readability
But if there are multiple dependencies with the same version I switch to the ext approach to ensure both libs are in sync
This might also explain why sometimes singlequotes and sometimes doublequotes are used. In singlequotes |
Exactly like this, preferred is single quotes and direct specification in the dependency and when there are multiple dependencies of a library that need or should have the same aligned version and do not have a bom managing the versions, extract the version to a property. However, this may not be kept consistent over time, e.g. otel deps had a lot of changes regarding what is managed in the bom and what has aligned versions that diverged later, etc. |
No description provided.