Skip to content

Update cafmakerjob_icarus_data.fcl #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Update cafmakerjob_icarus_data.fcl #823

wants to merge 2 commits into from

Conversation

nathanielerowe
Copy link
Contributor

Use new product labels. To be merged in alongside: SBNSoftware/sbncode#523.

Use new product labels
small typo in label name
Copy link
Member

@PetrilloAtWork PetrilloAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a suggestion for a different approach.

  1. leave the module labels the standard ones (bnbinfo, numiinfo, etc.)
  2. change the job configurations in sbncode so that the modules are called with matching names (bnbinfo etc.).

I can't see any reason for the bnbinfo label to be different between the two experiments, just like there is no reason for, say, CRT hit labels to be different.

See the proposed changed in PR #523.

@SBNSoftware SBNSoftware deleted a comment from FNALbuild Jun 12, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Jun 12, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Jun 12, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Jun 12, 2025
@leoaliaga
Copy link
Contributor

trigger build larsoft@v10_06_00 LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbnalg@v10_06_00_01 SBNSoftware/sbncode@v10_06_00_01 SBNSoftware/sbncode#523

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants