Skip to content

Cerati/feature nugraph2 #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 27 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
94abed0
first commit of NuGraphIcarus
cerati Mar 31, 2025
d728cdb
use IcarusNuSliceHitsProducer
cerati Apr 10, 2025
6f211ce
add script to start local triton server
cerati Apr 10, 2025
dc9e706
fix script name
cerati Apr 11, 2025
81247b4
take a quick nap to avoid starting a lar job before the server is ready
cerati Apr 11, 2025
23d0dfd
fix script names, add version for grid processing
cerati Apr 17, 2025
17f1e7b
no sleep better wait
cerati Apr 17, 2025
d9bed1c
add NuGraph to reco fcl, switch to libtorch inference by default
cerati May 2, 2025
8deda1b
make nugraph part of the pandora sequence
cerati May 2, 2025
e87380b
add icarus_postPandora_Gauss
cerati May 5, 2025
0aa9cdc
remove spurious character
cerati May 5, 2025
be34e0b
Merge tag 'v10_04_08' into cerati/feature_nugraph2
cerati May 6, 2025
cb5276c
restore cluster3D
cerati May 8, 2025
4eb87e5
Merge branch 'develop' into cerati/feature_nugraph2
cerati May 15, 2025
6f1406d
Merge branch 'develop' into cerati/feature_nugraph2
cerati May 27, 2025
70b8af6
add icarus_postPandora_Gauss to 1d fcl as well
cerati May 29, 2025
6f1b8b7
address G.P.'s comments
cerati Jun 6, 2025
f2c7261
moved NuGraph folder, improved fcl documentation
cerati Jun 9, 2025
ac05da7
remove cafmaker_nugraph_test.fcl
cerati Jun 9, 2025
5297b0c
rename Icarus to ICARUS
cerati Jun 9, 2025
a6a3c8f
remove fEventInfo
cerati Jun 9, 2025
2f14f07
fix assocSliceHitKeys usage
cerati Jun 10, 2025
c3b784b
restore correct behavior for allIDs, add PMT positions, fix SimChanne…
cerati Jun 10, 2025
438a62d
addressing comments
cerati Jun 11, 2025
55e0087
addressing comments
cerati Jun 11, 2025
d789fe9
improve documentation
cerati Jun 11, 2025
9e55de9
fix typo in description
cerati Jun 12, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ find_package(lardata REQUIRED )
find_package(larsim REQUIRED )
find_package(larevt REQUIRED )
find_package(larreco REQUIRED )
find_package(larrecodnn REQUIRED )
find_package(larana REQUIRED )
find_package(larpandora REQUIRED )
find_package(larpandoracontent REQUIRED )
Expand Down
3 changes: 3 additions & 0 deletions fcl/caf/cafmaker_defs.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,9 @@ cafmaker.SystWeightLabels: ["genieweight", "fluxweight"]
cafmaker.SaveGENIEEventRecord: true # save GENIE event record by default. Turn this off for data cafmaker fcl
cafmaker.TPCPMTBarycenterMatchLabel: "tpcpmtbarycentermatch"
cafmaker.TrackHitFillRREndCut: 30 # include entire PID region
cafmaker.NuGraphSliceHitLabel: "nuslhits"
cafmaker.NuGraphFilterLabel: "NuGraph:filter"
cafmaker.NuGraphSemanticLabel: "NuGraph:semantic"

# Add CAFMaker to the list of producers
caf_preprocess_producers.cafmaker: @local::cafmaker
Expand Down
24 changes: 21 additions & 3 deletions fcl/reco/Definitions/stage1_icarus_defs.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
#include "supera_modules.fcl"
#include "crtpmtmatching_parameters.fcl"
#include "tpcpmtbarycentermatch_config.fcl"
#include "nugraph_icarus.fcl"

BEGIN_PROLOG

Expand Down Expand Up @@ -71,6 +72,13 @@ icarus_stage1_producers:

tpcpmtbarycentermatchCryoE: @local::data_tpcpmtbarycentermatchproducer_east
tpcpmtbarycentermatchCryoW: @local::data_tpcpmtbarycentermatchproducer_west

## NuGraph
nuslhitsCryoE: @local::nuslhitsCryoE
nuslhitsCryoW: @local::nuslhitsCryoW
NuGraphCryoE: @local::NuGraphCryoE
NuGraphCryoW: @local::NuGraphCryoW

}

icarus_stage1_filters:
Expand Down Expand Up @@ -179,13 +187,19 @@ icarus_reco_cluster3DCryoW: [ cluster3DCryoW ]

icarus_reco_cluster3DCryoE: [ cluster3DCryoE ]

icarus_reco_pandoraGausCryoW: [ pandoraGausCryoW,
icarus_reco_pandoraGausCryoW: [ pandoraGausCryoW ]

icarus_reco_pandoraGausCryoE: [ pandoraGausCryoE ]

icarus_reco_postPandoraGausCryoW: [ nuslhitsCryoW,
NuGraphCryoW,
pandoraTrackGausCryoW,
pandoraKalmanTrackGausCryoW,
SBNShowerGausCryoW
]

icarus_reco_pandoraGausCryoE: [ pandoraGausCryoE,
icarus_reco_postPandoraGausCryoE: [ nuslhitsCryoE,
NuGraphCryoE,
pandoraTrackGausCryoE,
pandoraKalmanTrackGausCryoE,
SBNShowerGausCryoE
Expand All @@ -206,6 +220,11 @@ icarus_pandora_Gauss: [
@sequence::icarus_reco_pandoraGausCryoW
]

icarus_postPandora_Gauss: [
@sequence::icarus_reco_postPandoraGausCryoE,
@sequence::icarus_reco_postPandoraGausCryoW
]

#Add flash matching
icarus_reco_fm: [ fmatchCryoE,
fmatchCryoW,
Expand All @@ -224,7 +243,6 @@ icarus_crtt0match: [CRTT0Matching]
icarus_crtt0match_eff: [CRTT0MatchingE, CRTT0MatchingW]

### Below we include overrides for the modules above

## Overrides for filtering of cluster3D hits
icarus_stage1_filters.TPCHitFilterCryoW.HitDataLabelVec: ["cluster3DCryoW"]
icarus_stage1_filters.TPCHitFilterCryoW.MaximumHits: 60000
Expand Down
1 change: 1 addition & 0 deletions fcl/reco/Stage1/Run2/stage1_run2_icarus.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ physics.reco: [ @sequence::icarus_filter_cluster3D,
@sequence::icarus_pandora_Gauss,
@sequence::icarus_reco_fm,
@sequence::icarus_tpcpmtbarycentermatch,
@sequence::icarus_postPandora_Gauss,
@sequence::icarus_crttrack,
@sequence::icarus_crtt0match,
caloskimCalorimetryCryoE, caloskimCalorimetryCryoW]
Expand Down
4 changes: 2 additions & 2 deletions fcl/reco/Stage1/Run2/stage1_run2_icarus_MC.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@ physics.producers: {
}

physics.reco: [
@sequence::icarus_reco_Gauss_CryoE ,
@sequence::icarus_reco_Gauss_CryoW ,
@sequence::icarus_pandora_Gauss ,
@sequence::icarus_reco_fm,
@sequence::icarus_tpcpmtbarycentermatch,
@sequence::icarus_postPandora_Gauss ,
caloskimCalorimetryCryoE, caloskimCalorimetryCryoW,
mcassociationsGausCryoE, mcassociationsGausCryoW
]
Expand Down
1 change: 1 addition & 0 deletions icaruscode/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ add_subdirectory(Filters)
add_subdirectory(Generators)
add_subdirectory(Geometry)
add_subdirectory(LArG4)
add_subdirectory(NuGraphIcarus)
add_subdirectory(PMT)
add_subdirectory(RecoUtils)
add_subdirectory(TPC)
Expand Down
65 changes: 65 additions & 0 deletions icaruscode/NuGraphIcarus/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
cet_enable_asserts()

set( nugraph_tool_lib_list
lardataobj::RecoBase
lardataobj::AnalysisBase
larrecodnn::NuGraphBaseTools
TorchScatter::TorchScatter
art::Framework_Core
hep_concurrency::hep_concurrency
art_plugin_types::tool
)

include_directories($ENV{HEP_HPC_INC})

cet_build_plugin(IcarusNuGraphLoader art::tool
LIBRARIES PRIVATE
${nugraph_tool_lib_list}
)

simple_plugin(IcarusNuSliceHitsProducer "module"
LIBRARIES PRIVATE
art::Framework_Core
nusimdata::SimulationBase
lardataobj::RecoBase
lardataalg::DetectorInfo
lardata::DetectorInfoServices_DetectorClocksServiceStandard_service
larcore::Geometry_Geometry_service
sbnobj::Common_Reco
)

simple_plugin(IcarusTrueNuSliceHitsProducer "module"
LIBRARIES PRIVATE
art::Framework_Core
nusimdata::SimulationBase
lardataobj::RecoBase
lardataalg::DetectorInfo
lardata::DetectorInfoServices_DetectorClocksServiceStandard_service
larcore::Geometry_Geometry_service
sbnobj::Common_Reco
larsim::MCCheater_BackTrackerService_service
larsim::MCCheater_ParticleInventoryService_service
)

simple_plugin(IcarusHDF5Maker "module"
LIBRARIES PRIVATE
art::Framework_Core
nusimdata::SimulationBase
larsim::MCCheater_BackTrackerService_service
larsim::MCCheater_ParticleInventoryService_service
hep_hpc_hdf5
#hep::hpc_Utilities
lardata::RecoBaseProxy
lardataobj::RecoBase
lardataalg::DetectorInfo
lardata::DetectorInfoServices_DetectorClocksServiceStandard_service
larcore::Geometry_Geometry_service
${HDF5_LIBRARIES}
)

add_subdirectory(scripts)

install_headers()
install_fhicl()
install_source()

Loading