Skip to content

Updates to Enable Spring Production #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 122 commits into from
May 13, 2025
Merged

Conversation

gputnam
Copy link
Contributor

@gputnam gputnam commented Mar 24, 2025

This PR makes updates to icaruscode necessary to enable the Spring production. It depends on:
SBNSoftware/sbncode#526
WireCell/wire-cell-toolkit#400 (will need a new cut of WireCell+LArSoft with this in)
SBNSoftware/sbncode#535
SBNSoftware/sbnobj#129
SBNSoftware/icarus_signal_processing#24

It will need a new cut of icarus_data with the following files added in (please reach out to me to get them):
WirecellData/icarus_wire_twofaced.json.bz2
WirecellData/NNs/plane0.ts
WirecellData/NNs/plane1.ts
tpc_channelstatus_data.db (new copy with tag 'v3r4')

New PMT calibration database files are also needed (see #807). A new TPC calibration database file is also needed (see #792):
tpc_yz_correction_allplanes_data.db

It incorporates the following PRs (and can be merged either instead of or after those):
#774
#777
#817
#784
#809
#814
#816
#807
#819
#740
#818

It also incorporates #792, onto the develop branch.

This PR enables 2D signal processing for ICARUS, both flavors with and without DNN ROIs. It incorporates the "YZ" intransparency simulation, and organizes all of the recent development in ICARUS detector simulation into the mainline detsim config (see https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=40360). It extends @cerati's work in G4 configurations and reorganizes detsim, stage0, and stage1 configurations into a new, more orderly format. It incorporates ChannelROI-based region of interest objects (replacing recob::Wire's) to reduce file size. It moves hit finding from stage0 to stage1 to reduce file size and optimize memory usage. Finally, it also includes updates to the calibration NTupler to enable integration with the CRT (to T0 tag tracks).

mvicenzi and others added 30 commits March 6, 2024 11:56
This includes LVDS/adder bits, trigger logic and trigger tick (new!)
also for minimum bias events when such information is present.
This includes would-be trigger information in minimum bias events.
… jsonnets for various WC SP configs. Move parameters out of json config into fcl config.
@SBNSoftware SBNSoftware deleted a comment from FNALbuild May 9, 2025
@SBNSoftware SBNSoftware deleted a comment from gputnam May 9, 2025
@leoaliaga
Copy link
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbnalg@v10_06_00_01 SBNSoftware/sbncode@v10_06_00_01 SBNSoftware/icarus_signal_processing#24

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored failure for unit_test -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@SBNSoftware SBNSoftware deleted a comment from FNALbuild May 12, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild May 12, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild May 12, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild May 12, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild May 12, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild May 12, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild May 12, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild May 12, 2025
@leoaliaga
Copy link
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/icarus_signal_processing#24

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored failure for unit_test -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@gputnam
Copy link
Contributor Author

gputnam commented May 12, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbnalg@v10_06_00_01 SBNSoftware/sbncode@v10_06_00_01 SBNSoftware/icarus_signal_processing#24

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@leoaliaga leoaliaga merged commit aa6dd36 into develop May 13, 2025
2 of 4 checks passed
@leoaliaga leoaliaga deleted the release/Mar25Production branch May 13, 2025 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants