feat(ui5-date/time*): introduce translatable fallback placeholder #11739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsanislavgatev
requested changes
Jun 17, 2025
| } | ||
|
|
||
| // translatable placeholder – for example "e.g. 2025-12-31" | ||
| return `${DatePicker.i18nBundle.getText(DATETIME_COMPONENTS_PLACEHOLDER_PREFIX)} ${this._lastDayOfTheYear}`; |
There was a problem hiding this comment.
Can you try using this.getFormat().getPlaceholderText() ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when no
placeholderwas provided in our Date/Time components, the default placeholder simply displayed theformatPatternstring (e.g.,MMM d, y,dd/MM/yyyy - dd/MM/yyyy).With this change, if no
placeholderis set, the default placeholder now displays a translatable example value in the correctformatPattern/displayFormat— using the last value of the relevant period (such as the last day of the year, last hour of the day, etc.).Examples:
e.g. 23:59:59e.g. Dec 31, 2025Before
After