fix(ui5-tokenizer): fix token-delete event details #10630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivoplashkov
approved these changes
Jan 23, 2025
|
@ilhan007 I am not sure that you saw, but the build is failing for the PR. |
|
🎉 This PR is included in version v2.7.0 🎉 The release is available on v2.7.0 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the token-delete event details, because currently upon clicking the "X" of a token the token-delete event provides wrong token, actually undefined (as
this.tokensreturns the slot HTML elements, whilethis._tokensgets the slotted elements, the tokens, later correctly passed with the event as event.details.tokens).Fixes: #10612
Before: consumers can't perform deletion as they don't get the token that should be deleted:
After
Screen.Recording.2025-01-22.at.18.23.38.mov