Skip to content

chore: Update documentation #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 17, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,11 @@ globalaccount = "<YOUR GLOBAL ACCOUNT SUBDOMAIN>"
idp = null
```


The SAP BTP Global Account Subdomain can be found in the SAP BTP Cockpit as shown below
<img width="600px" src="assets/trial-account.png" alt="SAP BTP Global Account Subdomain">

The `idp` (Identity Provider Orgin Key ) is set to null. If a [Custom Identity Provider](https://help.sap.com/docs/btp/sap-business-technology-platform/log-on-with-custom-identity-provider-to-sap-btp-cockpit) is used to login to SAP BTP this value is set to Orgin Key of the Custom Identity Provider`
The `idp` (Identity Provider Orgin Key ) value is set to null. If a [SAP Cloud Identity Services tenant (Custom Identity Provider)](https://help.sap.com/docs/btp/sap-business-technology-platform/log-on-with-custom-identity-provider-to-sap-btp-cockpit) is used to login to SAP BTP Cockpit this value is set to Orgin Key of the Custom Identity Provider`. The orgin key of the SAP Cloud Identity Services tenant can be found in SAP BTP Cockpit. Go to the Global Account where teh Subaccount is being created. Navigate to Security -> Trust Configuration and the orgin key can be found under the Trust Configuration of the Identity Provider.

> [!NOTE]
> We are using here a naming convention of Terraform to define the variable values. The file `terraform.tfvars` is used to define the variable values. The file is not checked into the source code repository. This is important to keep sensitive information out of the source code repository. When you run Terraform, it will automatically load the variable values from this file.
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -40,20 +40,26 @@ We define a complex variable type, which is a [list](https://developer.hashicorp

## Step 2: Add the variable to the tfvars file

Now we need to specify the entitlements we want to create to the `terraform.tfvars` file.
Now we need to specify the entitlements we want to create to the `terraform.tfvars` file.

We want to add the following entitlements to the subaccount:

- `sapappstudiotrial` application with the `trial` plan

Open the `terraform.tfvars` file and add the following code:
If you are creating subaccount in **SAP BTP Trial landscape**, open the `terraform.tfvars` file and add the following code:

```terraform
bas_service_name = "sapappstudiotrial"
bas_plan = "trial"
bas_admins = ["admin1@example.com", "admin2@example.com"]
bas_developers = ["dev1@example.com", "dev2@example.com"]
```
OR

If you are creating Subaccount in **Live or Production landscapes** such as `EU10`, `US10`, `AP10` etc, open the `terraform.tfvars` file and add the following code:

```terraform
bas_service_name = "sapappstudio"
bas_plan = "standard-edition"
bas_admins = ["admin1@example.com", "admin2@example.com"]
bas_developers = ["dev1@example.com", "dev2@example.com"]
```

## Step 3: Add the entitlements configuration

Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,20 @@ resource "btp_subaccount_environment_instance" "cloudfoundry" {
```
### Step 2: Add the variables to tfvar file

Add following variables to your `tfvars` file to configure the CloudFoundry Plan.
If you are creating subaccount in **SAP BTP Trial landscape**, open the `terraform.tfvars` file and add the following variable:

```terraform
cf_plan = "trial"
```
**OR**

If you are creating subaccount in **Live or Production landscapes** such as `EU10`, `US10`, `AP10` etc, open the `terraform.tfvars` file and add the following variable:

```terraform
cf_plan = "standard"
```
Save the changes.

### Step 3: Adjust the output variables

As we are using the output variables, we need to adjust the output variables in the `outputs.tf` file. Open the `outputs.tf` file and add the following code:
Expand Down Expand Up @@ -99,4 +107,4 @@ output "cloudfoundry_org_name" {

You've now successfully created a Cloud Foundry environment instance as well as a Cloud Foundry space in SAP BTP.

Continue to - [Exercise 5 - Create a CloudFoundry Space](../EXERCISE5/README.md).
Continue to - [Exercise 5 - Create a CloudFoundry Space](../EXERCISE5/README.md).
Loading
Loading